-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#545][FOLLOWUP]feat(operator): support specifying custom tolerations #638
Conversation
PTAL @wangao1236 @advancedxy |
Thanks @crain-cn for the work. Please take a look at the test failures in CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cloud you add some UTs for this new field?
deploy/kubernetes/operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go
Outdated
Show resolved
Hide resolved
deploy/kubernetes/operator/api/uniffle/v1alpha1/remoteshuffleservice_types.go
Show resolved
Hide resolved
deploy/kubernetes/operator/pkg/controller/sync/coordinator/coordinator.go
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #638 +/- ##
============================================
- Coverage 60.89% 60.67% -0.22%
- Complexity 1798 1799 +1
============================================
Files 214 216 +2
Lines 12381 12468 +87
Branches 1042 1052 +10
============================================
+ Hits 7539 7565 +26
- Misses 4438 4496 +58
- Partials 404 407 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
c221a99
to
db53af8
Compare
db53af8
to
39e6157
Compare
@crain-cn Could you add some uts for this pr? |
NodeSelector: rss.Spec.Coordinator.NodeSelector, | ||
Tolerations: rss.Spec.Coordinator.Tolerations, | ||
Volumes: rss.Spec.Coordinator.Volumes, | ||
NodeSelector: rss.Spec.Coordinator.NodeSelector, | ||
} | ||
configurationVolume := corev1.Volume{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configurationVolume := corev1.Volume{ | |
if len(podSpec.Tolerations) == 0 { | |
podSpec.Tolerations = []corev1.Toleration{...} # the default master rule toleration | |
} | |
configurationVolume := corev1.Volume{ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 😄 @advancedxy
|
@advancedxy Affinity fields , can I submit to the next pr? |
of course. |
Thanks ! 😄 |
Can I make it up later? |
|
What changes were proposed in this pull request?
Support coordinator/shuffler server's tolerations to the fields of RSS spec
Why are the changes needed?
Does this PR introduce any user-facing change?
For RSS cluster admin, they can set custom tolerations for shuffle servers and coordinators.
How was this patch tested?
Manually verified.