-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #438] Enable Github Actions for Checkstyle #439
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #439 +/- ##
============================================
+ Coverage 2.93% 8.49% +5.55%
- Complexity 89 256 +167
============================================
Files 224 228 +4
Lines 10754 10783 +29
Branches 921 918 -3
============================================
+ Hits 316 916 +600
+ Misses 10392 9793 -599
- Partials 46 74 +28
Continue to review full report at Codecov.
|
5d99e61
to
2071d58
Compare
We can also use the checkstyle plugin in IDEA to help us check our code style. |
5e5d718
to
77c1195
Compare
@ruanwenjun Thanks for your comments!
Sure! This can make our codebase healthy and clean!
I only added the following checks in the Checkstyle configuration file:
When we have a clear code style, we can add more constraints. |
77c1195
to
05b10c2
Compare
@SteveYurongSu Great |
8fb45cc
to
a204562
Compare
@SteveYurongSu Will it become easier failed each build? |
I only added the following checks in the Checkstyle configuration file:
If a checkstyle workflow fails, there must be a finding related to one of the above cases, which means the author must modify the code. 😆 |
LGTM |
* enable github actions for checkstyle * try to fix ci * ... * ... * ... * Enable Github Actions for Checkstyle * accelerate * -filter-mode=nofilter -fail-on-error * remove -name
* enable github actions for checkstyle * try to fix ci * ... * ... * ... * Enable Github Actions for Checkstyle * accelerate * -filter-mode=nofilter -fail-on-error * remove -name
Fixes ISSUE #438.
Motivation
Explain the content here.
Explain why you want to make the changes and what problem you're trying to solve.
I noticed that there are folks working on issue #428 (#431), translating or removing Chinese chars in code.
Manually checking for this kind of code style can be a pain.
But, we can make the process of code style check automated with less pain by introducing Checkstyle into CI.
Modifications
Describe the modifications you've done.