Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Github Actions for Checkstyle #438

Closed
SteveYurongSu opened this issue Jul 15, 2021 · 2 comments
Closed

Enable Github Actions for Checkstyle #438

SteveYurongSu opened this issue Jul 15, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@SteveYurongSu
Copy link
Member

SteveYurongSu commented Jul 15, 2021

Enhancement Request

Is your enhancement request related to a problem? Please describe

I noticed that there are folks working on issue #428 (#431), translating or removing Chinese chars in code.
Manually checking for this kind of code style can be a pain.
But, we can make the process of code style check automated with less pain by introducing Checkstyle into CI.

Describe the solution you'd like

I'd like to define a Checkstyle workflow in CI.
The Checkstyle workflow will fail if a bad code style is found and will provide a report after each run.
The report includes the code style issues found in the workflow, and it can be a reference for reviewers.

Describe alternatives you've considered

  • Github Actions: Checkstyle check + reviewdog report
  • Github Actions: Spotless check

Additional context

reviewdog: https://github.com/reviewdog/reviewdog
checkstyle-idea: https://plugins.jetbrains.com/plugin/1065-checkstyle-idea

@SteveYurongSu
Copy link
Member Author

Yes, we can also check our code style in IDE.

image

@SteveYurongSu
Copy link
Member Author

Hi @qqeasonchen @xwm1992 , my PR is ready, please take a look 😊😊
BTW, This PR may help #428 (#431).

qqeasonchen pushed a commit that referenced this issue Jul 16, 2021
* enable github actions for checkstyle

* try to fix ci

* ...

* ...

* ...

* Enable Github Actions for Checkstyle

* accelerate

* -filter-mode=nofilter -fail-on-error

* remove -name
jjz921024 pushed a commit to jjz921024/incubator-eventmesh that referenced this issue Jul 25, 2021
* enable github actions for checkstyle

* try to fix ci

* ...

* ...

* ...

* Enable Github Actions for Checkstyle

* accelerate

* -filter-mode=nofilter -fail-on-error

* remove -name
xwm1992 pushed a commit to xwm1992/EventMesh that referenced this issue Dec 27, 2021
* enable github actions for checkstyle

* try to fix ci

* ...

* ...

* ...

* Enable Github Actions for Checkstyle

* accelerate

* -filter-mode=nofilter -fail-on-error

* remove -name
xwm1992 pushed a commit that referenced this issue Aug 4, 2022
* enable github actions for checkstyle

* try to fix ci

* ...

* ...

* ...

* Enable Github Actions for Checkstyle

* accelerate

* -filter-mode=nofilter -fail-on-error

* remove -name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant