-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Github Actions for Checkstyle #438
Labels
enhancement
New feature or request
Comments
Hi @qqeasonchen @xwm1992 , my PR is ready, please take a look 😊😊 |
qqeasonchen
pushed a commit
that referenced
this issue
Jul 16, 2021
This was referenced Jul 17, 2021
jjz921024
pushed a commit
to jjz921024/incubator-eventmesh
that referenced
this issue
Jul 25, 2021
* enable github actions for checkstyle * try to fix ci * ... * ... * ... * Enable Github Actions for Checkstyle * accelerate * -filter-mode=nofilter -fail-on-error * remove -name
xwm1992
pushed a commit
to xwm1992/EventMesh
that referenced
this issue
Dec 27, 2021
* enable github actions for checkstyle * try to fix ci * ... * ... * ... * Enable Github Actions for Checkstyle * accelerate * -filter-mode=nofilter -fail-on-error * remove -name
xwm1992
pushed a commit
that referenced
this issue
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Enhancement Request
Is your enhancement request related to a problem? Please describe
I noticed that there are folks working on issue #428 (#431), translating or removing Chinese chars in code.
Manually checking for this kind of code style can be a pain.
But, we can make the process of code style check automated with less pain by introducing Checkstyle into CI.
Describe the solution you'd like
I'd like to define a Checkstyle workflow in CI.
The Checkstyle workflow will fail if a bad code style is found and will provide a report after each run.
The report includes the code style issues found in the workflow, and it can be a reference for reviewers.
Describe alternatives you've considered
Additional context
reviewdog: https://github.com/reviewdog/reviewdog
checkstyle-idea: https://plugins.jetbrains.com/plugin/1065-checkstyle-idea
The text was updated successfully, but these errors were encountered: