[opt](jdbc catalog) Compatible with higher ClickHouse JDBC Driver versions #46026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 32422 ms |
TPC-DS: Total hot run time: 190176 ms |
ClickBench: Total hot run time: 31.42 s |
|
This pull request introduces significant enhancements to the Enhancements to
|
morningman
reviewed
Dec 30, 2024
| private boolean determineDatabaseTerm() { | ||
| try (Connection conn = getConnection()) { | ||
| String jdbcUrl = conn.getMetaData().getURL(); | ||
| // 获取驱动版本是否大于等于 0.5.0 |
| * true will be returned. | ||
| * 2. If it is an old version driver (<0.5.0), always returns false. | ||
| */ | ||
| private boolean isDatabaseTermCatalog() { |
There was a problem hiding this comment.
I suggest to check and fill the databaseTermIsCatalog when creating the catalog.
(for old version, user can call refresh to fill this field, added to the document).
So that we don't need to use this synchronized things, which make the code hard to maintain.
|
run buildall |
TPC-H: Total hot run time: 32848 ms |
TPC-DS: Total hot run time: 189085 ms |
ClickBench: Total hot run time: 31.12 s |
morningman
reviewed
Jan 14, 2025
| @@ -379,10 +378,11 @@ private void testJdbcConnection() throws DdlException { | |||
|
|
|||
| private void testFeToJdbcConnection() throws DdlException { | |||
| try { | |||
| initLocalObjectsImpl(); | |||
There was a problem hiding this comment.
Why move this method to here?
There was a problem hiding this comment.
Initializing the client in the method that tests FE's external connection is more convenient for process control, rather than outside this method
| String[] versionParts = driverVersion.split("\\."); | ||
| int majorVersion = Integer.parseInt(versionParts[0]); | ||
| int minorVersion = Integer.parseInt(versionParts[1]); | ||
| // 判断是否大于等于 0.5.x |
There was a problem hiding this comment.
English.
And we should add UT for this method
613e095 to
9ab4125
Compare
9ab4125 to
2e8831c
Compare
|
run buildall |
TPC-H: Total hot run time: 32438 ms |
TPC-DS: Total hot run time: 194020 ms |
ClickBench: Total hot run time: 31.34 s |
wuwenchi
approved these changes
Jan 22, 2025
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
zy-kkk
added a commit
to zy-kkk/doris
that referenced
this pull request
Feb 12, 2025
…sions (apache#46026) ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: 1. Since clickhouse changes the database level in jdbc metadata from schema to catalog in JDBC Driver 0.5.0 and later, we need to be compatible with this change 2. Since clickhouse JDBC Driver supports getting metadata from prepared statements only in Driver version 0.6.2 and later, if you use query tvf to query clickhouse catalog, you need to use a driver later than this version 3. Delete some tests and add them again later
zy-kkk
added a commit
to zy-kkk/doris
that referenced
this pull request
Feb 12, 2025
…sions (apache#46026) ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: 1. Since clickhouse changes the database level in jdbc metadata from schema to catalog in JDBC Driver 0.5.0 and later, we need to be compatible with this change 2. Since clickhouse JDBC Driver supports getting metadata from prepared statements only in Driver version 0.6.2 and later, if you use query tvf to query clickhouse catalog, you need to use a driver later than this version 3. Delete some tests and add them again later
github-actions bot
pushed a commit
that referenced
this pull request
Feb 21, 2025
…sions (#46026) ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: 1. Since clickhouse changes the database level in jdbc metadata from schema to catalog in JDBC Driver 0.5.0 and later, we need to be compatible with this change 2. Since clickhouse JDBC Driver supports getting metadata from prepared statements only in Driver version 0.6.2 and later, if you use query tvf to query clickhouse catalog, you need to use a driver later than this version 3. Delete some tests and add them again later
lzyy2024
pushed a commit
to lzyy2024/doris
that referenced
this pull request
Feb 21, 2025
…sions (apache#46026) ### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: 1. Since clickhouse changes the database level in jdbc metadata from schema to catalog in JDBC Driver 0.5.0 and later, we need to be compatible with this change 2. Since clickhouse JDBC Driver supports getting metadata from prepared statements only in Driver version 0.6.2 and later, if you use query tvf to query clickhouse catalog, you need to use a driver later than this version 3. Delete some tests and add them again later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)