Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](load) fix no error url for stream load #38325 #38417

Merged
merged 1 commit into from
Jul 28, 2024
Merged

[fix](load) fix no error url for stream load #38325 #38417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions be/src/runtime/stream_load/stream_load_executor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,7 @@ Status StreamLoadExecutor::execute_plan_fragment(std::shared_ptr<StreamLoadConte
// some users may rely on this error message.
*status = Status::DataQualityError("too many filtered rows");
}
if (ctx->number_filtered_rows > 0 && !state->get_error_log_file_path().empty()) {
ctx->error_url = to_load_error_http_path(state->get_error_log_file_path());
}
ctx->error_url = to_load_error_http_path(state->get_error_log_file_path());

if (status->ok()) {
DorisMetrics::instance()->stream_receive_bytes_total->increment(ctx->receive_bytes);
Expand Down
42 changes: 41 additions & 1 deletion regression-test/suites/load_p0/stream_load/test_stream_load.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,15 @@ suite("test_stream_load", "p0") {

file 'test_strict_mode.csv'
time 10000 // limit inflight 10s
check { result, exception, startTime, endTime ->
if (exception != null) {
throw exception
}
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
}
}

sql "sync"
Expand All @@ -90,6 +99,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("fail", json.Status.toLowerCase())
assertTrue(result.contains("ErrorURL"))
assertEquals(2, json.NumberTotalRows)
assertEquals(1, json.NumberFilteredRows)
}
Expand Down Expand Up @@ -117,6 +127,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(result.contains("ErrorURL"))
assertEquals(2, json.NumberTotalRows)
assertEquals(1, json.NumberFilteredRows)
}
Expand Down Expand Up @@ -160,6 +171,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(3, json.NumberTotalRows)
assertEquals(0, json.NumberFilteredRows)
}
Expand Down Expand Up @@ -210,6 +222,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(1, json.NumberTotalRows)
assertEquals(0, json.NumberFilteredRows)
}
Expand Down Expand Up @@ -428,6 +441,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
}
}
sql "sync"
Expand All @@ -453,6 +467,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
}
}
sql "sync"
Expand All @@ -474,6 +489,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(4, json.NumberTotalRows)
assertEquals(0, json.NumberFilteredRows)
}
Expand All @@ -497,6 +513,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(2500, json.NumberTotalRows)
assertEquals(0, json.NumberFilteredRows)
}
Expand Down Expand Up @@ -524,6 +541,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("fail", json.Status.toLowerCase())
assertTrue(result.contains("ErrorURL"))
assertEquals(0, json.NumberLoadedRows)
}
}
Expand All @@ -547,6 +565,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(2500, json.NumberTotalRows)
assertEquals(2500, json.NumberLoadedRows)
assertEquals(0, json.NumberFilteredRows)
Expand Down Expand Up @@ -579,6 +598,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(2500, json.NumberTotalRows)
assertEquals(11, json.NumberLoadedRows)
assertEquals(0, json.NumberFilteredRows)
Expand Down Expand Up @@ -609,6 +629,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(2500, json.NumberTotalRows)
assertEquals(2500, json.NumberLoadedRows)
assertEquals(0, json.NumberFilteredRows)
Expand Down Expand Up @@ -639,6 +660,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(result.contains("ErrorURL"))
assertEquals(2500, json.NumberTotalRows)
assertEquals(0, json.NumberLoadedRows)
assertEquals(2500, json.NumberFilteredRows)
Expand Down Expand Up @@ -695,6 +717,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(1025, json.NumberTotalRows)
assertEquals(1025, json.NumberLoadedRows)
assertEquals(0, json.NumberFilteredRows)
Expand Down Expand Up @@ -723,6 +746,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(8001, json.NumberTotalRows)
assertEquals(8001, json.NumberLoadedRows)
assertEquals(0, json.NumberFilteredRows)
Expand Down Expand Up @@ -754,6 +778,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(6, json.NumberTotalRows)
assertEquals(6, json.NumberLoadedRows)
assertEquals(0, json.NumberFilteredRows)
Expand Down Expand Up @@ -782,6 +807,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(5, json.NumberTotalRows)
assertEquals(5, json.NumberLoadedRows)
assertEquals(0, json.NumberFilteredRows)
Expand Down Expand Up @@ -834,6 +860,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(10, json.NumberTotalRows)
assertEquals(10, json.NumberLoadedRows)
assertEquals(0, json.NumberFilteredRows)
Expand Down Expand Up @@ -884,6 +911,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(5, json.NumberTotalRows)
assertEquals(5, json.NumberLoadedRows)
assertEquals(0, json.NumberFilteredRows)
Expand Down Expand Up @@ -936,6 +964,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(14, json.NumberTotalRows)
assertEquals(14, json.NumberLoadedRows)
assertEquals(0, json.NumberFilteredRows)
Expand Down Expand Up @@ -990,6 +1019,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(11, json.NumberTotalRows)
assertEquals(0, json.NumberFilteredRows)
assertEquals(5, json.NumberUnselectedRows)
Expand Down Expand Up @@ -1042,6 +1072,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(2, json.NumberTotalRows)
assertEquals(0, json.NumberFilteredRows)
assertEquals(0, json.NumberUnselectedRows)
Expand Down Expand Up @@ -1084,6 +1115,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(2, json.NumberTotalRows)
assertEquals(0, json.NumberFilteredRows)
assertEquals(0, json.NumberUnselectedRows)
Expand Down Expand Up @@ -1224,6 +1256,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(2, json.NumberTotalRows)
assertEquals(0, json.NumberFilteredRows)
assertEquals(0, json.NumberUnselectedRows)
Expand Down Expand Up @@ -1253,6 +1286,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
assertEquals(2, json.NumberTotalRows)
assertEquals(0, json.NumberFilteredRows)
assertEquals(0, json.NumberUnselectedRows)
Expand Down Expand Up @@ -1370,6 +1404,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
}
}
sql "sync"
Expand All @@ -1391,6 +1426,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
}
}
sql "sync"
Expand Down Expand Up @@ -1447,6 +1483,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
}
}

Expand All @@ -1464,6 +1501,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
}
}

Expand All @@ -1483,6 +1521,7 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("success", json.Status.toLowerCase())
assertTrue(!result.contains("ErrorURL"))
}
}
sql "sync"
Expand Down Expand Up @@ -1566,7 +1605,8 @@ suite("test_stream_load", "p0") {
log.info("Stream load result: ${result}".toString())
def json = parseJson(result)
assertEquals("fail", json.Status.toLowerCase())
assertTrue(json.Message.contains("[DATA_QUALITY_ERROR]Encountered unqualified data, stop processing"))
assertTrue(result.contains("ErrorURL"))
assertTrue(json.Message.contains("Encountered unqualified data, stop processing"))
}
}
} finally {
Expand Down
Loading