Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](load) fix no error url for stream load #38325 #38417

Merged

Conversation

liaoxin01
Copy link
Contributor

cherry pick from #38325

Previously, it was determined whether to output an error URL based on
whether num_filtered_rows was greater than 0. However, in abnormal
situations, the statistics of num_filtered_rows may not be accurate,
resulting in no error URL output. As long as there is data in the error
log file indicating filtered rows, the URL can be returned to the client
without the need to determine the number of filtered rows.
@liaoxin01
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.43% (9253/25397)
Line Coverage: 27.99% (75649/270285)
Region Coverage: 26.80% (38881/145099)
Branch Coverage: 23.53% (19731/83862)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c87ef3483529d682e1cafa637768cb0f866acef3_c87ef3483529d682e1cafa637768cb0f866acef3/report/index.html

@liaoxin01 liaoxin01 merged commit e9f12fa into apache:branch-2.1 Jul 28, 2024
20 of 22 checks passed
@liaoxin01 liaoxin01 deleted the pick_38325_to_origin_branch-2.1 branch July 28, 2024 11:06
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants