[fix] (compile) Resolve time_point type mismatch in s3_rate_limiter.cpp in mac #38036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
Yukang-Lian
approved these changes
Jul 18, 2024
|
PR approved by anyone and no changes requested. |
|
PR approved by at least one committer and no changes requested. |
zy-kkk
added a commit
that referenced
this pull request
Jul 18, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 19, 2024
…pp in mac (#38036) A compilation error in `s3_rate_limiter.cpp` due to a type mismatch between `std::chrono::system_clock::time_point` and `std::chrono::high_resolution_clock::time_point`，Updated the `_update_remain_token` function to accept `std::chrono::high_resolution_clock::time_point` instead of `std::chrono::system_clock::time_point` on MacOS。
dataroaring
pushed a commit
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
A compilation error in
s3_rate_limiter.cppdue to a type mismatch betweenstd::chrono::system_clock::time_pointandstd::chrono::high_resolution_clock::time_point，Updated the_update_remain_tokenfunction to acceptstd::chrono::high_resolution_clock::time_pointinstead ofstd::chrono::system_clock::time_pointon MacOS。