Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix][compile] Resolve time_point type mismatch on MacOS and Linux #34054

Merged
merged 1 commit into from
Apr 24, 2024
Merged

[fix][compile] Resolve time_point type mismatch on MacOS and Linux #34054

merged 1 commit into from
Apr 24, 2024

Conversation

zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Apr 24, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zy-kkk
Copy link
Member Author

zy-kkk commented Apr 24, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Lchangliang
Copy link
Contributor

LGTM

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.21% (8916/25322)
Line Coverage: 26.98% (73347/271840)
Region Coverage: 26.15% (37888/144869)
Branch Coverage: 22.97% (19294/83980)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f4dfafdb20784ad6a9ab844b424bf96756756110_f4dfafdb20784ad6a9ab844b424bf96756756110/report/index.html

@zy-kkk zy-kkk merged commit 0132ef8 into apache:master Apr 24, 2024
24 of 29 checks passed
@zy-kkk zy-kkk deleted the mac_compile_0424 branch April 24, 2024 07:19
@zy-kkk zy-kkk mentioned this pull request Jul 18, 2024
Merged
zy-kkk added a commit that referenced this pull request Jul 18, 2024
@zy-kkk
[fix][compile] Resolve time_point type mismatch on MacOS and Linux (#…
ba0eb23 
…38049)

revert #38036
We cannot change the time_point type directly, but use macros to
distinguish different compilation platforms, refer to #34054
dataroaring pushed a commit that referenced this pull request Jul 19, 2024
@zy-kkk @dataroaring
[fix][compile] Resolve time_point type mismatch on MacOS and Linux (#…
ade14e4 
…38049)

revert #38036
We cannot change the time_point type directly, but use macros to
distinguish different compilation platforms, refer to #34054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonis0147 adonis0147 adonis0147 approved these changes

@Lchangliang Lchangliang Lchangliang approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zy-kkk @doris-robot @Lchangliang @adonis0147