Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](planner) Failed to create table with CTAS when multiple varchar type filed as key #18814

Merged
merged 1 commit into from
Apr 21, 2023
Merged

[fix](planner) Failed to create table with CTAS when multiple varchar type filed as key #18814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
import org.apache.doris.analysis.DropPartitionClause;
import org.apache.doris.analysis.DropTableStmt;
import org.apache.doris.analysis.Expr;
import org.apache.doris.analysis.FunctionCallExpr;
import org.apache.doris.analysis.HashDistributionDesc;
import org.apache.doris.analysis.KeysDesc;
import org.apache.doris.analysis.LinkDbStmt;
Expand Down Expand Up @@ -1221,6 +1222,7 @@ public void createTableAsSelect(CreateTableAsSelectStmt stmt) throws DdlExceptio
List<String> columnNames = stmt.getColumnNames();
CreateTableStmt createTableStmt = stmt.getCreateTableStmt();
QueryStmt queryStmt = stmt.getQueryStmt();
KeysDesc keysDesc = createTableStmt.getKeysDesc();
ArrayList<Expr> resultExprs = queryStmt.getResultExprs();
ArrayList<String> colLabels = queryStmt.getColLabels();
int size = resultExprs.size();
Expand All @@ -1242,7 +1244,11 @@ public void createTableAsSelect(CreateTableAsSelectStmt stmt) throws DdlExceptio
TypeDef typeDef;
Expr resultExpr = resultExprs.get(i);
Type resultType = resultExpr.getType();
if (resultType.isStringType()) {
if (resultExpr instanceof FunctionCallExpr
&& resultExpr.getType().getPrimitiveType().equals(PrimitiveType.VARCHAR)) {
resultType = ScalarType.createVarchar(65533);
}
if (resultType.isStringType() && (keysDesc == null || !keysDesc.containsCol(name))) {
// Use String for varchar/char/string type,
// to avoid char-length-vs-byte-length issue.
typeDef = new TypeDef(ScalarType.createStringType());
Expand Down
2 changes: 1 addition & 1 deletion fe/fe-core/src/test/java/org/apache/doris/analysis/CreateTableAsSelectStmtTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ public void testUseKeyType() throws Exception {
ShowResultSet showResultSet = showCreateTableByName("test_use_key_type");
Assertions.assertEquals(
"CREATE TABLE `test_use_key_type` (\n"
+ " `userId` varchar(65533) NOT NULL,\n"
+ " `userId` varchar(255) NOT NULL,\n"
+ " `username` text NOT NULL\n"
+ ") ENGINE=OLAP\n"
+ "UNIQUE KEY(`userId`)\n"
Expand Down
49 changes: 49 additions & 0 deletions regression-test/suites/ddl_p0/test_ctas.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,51 @@ suite("test_ctas") {
rowNum 6
}

sql """
create table if not exists test_tbl_81748325
(
`col1` varchar(66) not null ,
`col2` bigint not null ,
`col3` varchar(66) not null ,
`col4` varchar(42) not null ,
`col5` bigint not null ,
`col6` bigint not null ,
`col7` datetime not null ,
`col8` varchar(66) not null,
`col9` varchar(66) ,
`col10` varchar(66) ,
`col11` varchar(66) ,
`col12` text
)
UNIQUE KEY (`col1`,`col2`,`col3`,`col4`,`col5`,`col6`)
DISTRIBUTED BY HASH(`col4`) BUCKETS 1
PROPERTIES (
"replication_allocation" = "tag.location.default: 1"
);
"""

sql """
create table `test_tbl_3156019`
UNIQUE KEY (col4,col3,from_address,to_address)
DISTRIBUTED BY HASH (col4) BUCKETS 1
PROPERTIES (
"replication_allocation" = "tag.location.default: 1"
)
as
select
col4 as col4,
col3 as col3,
concat('0x', substring(col9, 27)) as from_address,
concat('0x', substring(col10, 27)) as to_address,
col7 as date_time,
now() as update_time,
'20230318' as pt,
col8 as amount
from test_tbl_81748325
where col4 = '43815251'
and substring(col8, 1, 10) = '1451601';
"""

} finally {
sql """ DROP TABLE IF EXISTS test_ctas """

Expand All @@ -119,6 +164,10 @@ suite("test_ctas") {
sql """ DROP TABLE IF EXISTS test_ctas_json_object1 """

sql """drop table if exists a"""

sql """DROP TABLE IF EXISTS test_tbl_81748325"""

sql """DROP TABLE IF EXISTS test_tbl_3156019"""
}

}
Expand Down