Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](planner) Failed to create table with CTAS when multiple varchar type filed as key #18814

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

Kikyou1997
Copy link
Contributor

@Kikyou1997 Kikyou1997 commented Apr 19, 2023

Proposed changes

Add restricton for converting varchar/char to string type, only fields that is string type and not in key desc could be convert to string type now.

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Kikyou1997
Copy link
Contributor Author

run buildall

@Kikyou1997
Copy link
Contributor Author

run buildall

@Kikyou1997
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 21, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 063dfef into apache:master Apr 21, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
… type filed as key (apache#18814)

Add restricton for converting varchar/char to string type, only fields that is string type and not in key desc could be convert to string type now.
xiaokang pushed a commit to xiaokang/doris that referenced this pull request Apr 22, 2023
… type filed as key (apache#18814)

Add restricton for converting varchar/char to string type, only fields that is string type and not in key desc could be convert to string type now.
@yiguolei yiguolei added the usercase Important user case type label label Apr 23, 2023
morningman pushed a commit that referenced this pull request Apr 30, 2023
… type filed as key (#18814)

Add restricton for converting varchar/char to string type, only fields that is string type and not in key desc could be convert to string type now.
Reminiscent pushed a commit to Reminiscent/doris that referenced this pull request May 15, 2023
… type filed as key (apache#18814)

Add restricton for converting varchar/char to string type, only fields that is string type and not in key desc could be convert to string type now.
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
… type filed as key (apache#18814)

Add restricton for converting varchar/char to string type, only fields that is string type and not in key desc could be convert to string type now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/1.2.5-merged kind/test reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants