[Fix](topn opt) double check plan From OriginalPlanner to make sure o… #16848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptimized SQL is a general topn query From the original logic, query like `select * from a where exists (select * from b order by 1) order by 1 limit 1` is a query contains subquery, but the top query will pass `checkEnableTwoPhaseRead` and set `isTwoPhaseOptEnabled=true`.So check the double plan is a general topn query plan is needed, and rollback the needMaterialize flag setted by the previous `analyze`.
yagagagaga
pushed a commit
to yagagagaga/doris
that referenced
this pull request
Mar 9, 2023
…ptimized SQL is a general topn query (apache#16848) From the original logic, query like `select * from a where exists (select * from b order by 1) order by 1 limit 1` is a query contains subquery, but the top query will pass `checkEnableTwoPhaseRead` and set `isTwoPhaseOptEnabled=true`.So check the double plan is a general topn query plan is needed, and rollback the needMaterialize flag setted by the previous `analyze`.
5 tasks
morrySnow
added a commit
that referenced
this pull request
Apr 21, 2023
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
add two phase read topn opt, the legacy planner's PR are: - apache#15642 - apache#16460 - apache#16848 TODO: we forbid limit(sort(project(scan))) since be core when plan has a project on the scan. we need to remove this restirction after we fix be bug
xiaokang
pushed a commit
to xiaokang/doris
that referenced
this pull request
Apr 22, 2023
add two phase read topn opt, the legacy planner's PR are: - apache#15642 - apache#16460 - apache#16848 TODO: we forbid limit(sort(project(scan))) since be core when plan has a project on the scan. we need to remove this restirction after we fix be bug
Reminiscent
pushed a commit
to Reminiscent/doris
that referenced
this pull request
May 15, 2023
add two phase read topn opt, the legacy planner's PR are: - apache#15642 - apache#16460 - apache#16848 TODO: we forbid limit(sort(project(scan))) since be core when plan has a project on the scan. we need to remove this restirction after we fix be bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ptimized SQL is a general topn query
From the original logic, query like
select * from a where exists (select * from b order by 1) order by 1 limit 1is a query contains subquery, but the top query will passcheckEnableTwoPhaseReadand setisTwoPhaseOptEnabled=true.So double check the plan is a general topn query plan is needed, and rollback the needMaterialize flag setted by the previousanalyze.Proposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...