-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug](sort) disable 2phase read for sort by expressions exclude slotref #16460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeamCity pipeline, clickbench performance test result: |
``` create table tbl1 (k1 varchar(100), k2 string) distributed by hash(k1) buckets 1 properties("replication_num" = "1"); insert into tbl1 values(1, "alice"); select cast(k1 as INT) as id from tbl1 order by id limit 2; ``` The above query could pass `checkEnableTwoPhaseRead` since the order by element is SlotRef but actually it's an function call expr
Gabriel39
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
YangShaw
pushed a commit
to YangShaw/doris
that referenced
this pull request
Feb 17, 2023
…ef (apache#16460) ``` create table tbl1 (k1 varchar(100), k2 string) distributed by hash(k1) buckets 1 properties("replication_num" = "1"); insert into tbl1 values(1, "alice"); select cast(k1 as INT) as id from tbl1 order by id limit 2; ``` The above query could pass `checkEnableTwoPhaseRead` since the order by element is SlotRef but actually it's an function call expr
5 tasks
morrySnow
added a commit
that referenced
this pull request
Apr 21, 2023
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
add two phase read topn opt, the legacy planner's PR are: - apache#15642 - apache#16460 - apache#16848 TODO: we forbid limit(sort(project(scan))) since be core when plan has a project on the scan. we need to remove this restirction after we fix be bug
xiaokang
pushed a commit
to xiaokang/doris
that referenced
this pull request
Apr 22, 2023
add two phase read topn opt, the legacy planner's PR are: - apache#15642 - apache#16460 - apache#16848 TODO: we forbid limit(sort(project(scan))) since be core when plan has a project on the scan. we need to remove this restirction after we fix be bug
Reminiscent
pushed a commit
to Reminiscent/doris
that referenced
this pull request
May 15, 2023
add two phase read topn opt, the legacy planner's PR are: - apache#15642 - apache#16460 - apache#16848 TODO: we forbid limit(sort(project(scan))) since be core when plan has a project on the scan. we need to remove this restirction after we fix be bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The above query could pass
checkEnableTwoPhaseRead
since the order by element is SlotRef but actually it's an function call exprProposed changes
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...