Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md updates #1141

Merged
merged 1 commit into from
Dec 6, 2024
Merged

README.md updates #1141

merged 1 commit into from
Dec 6, 2024

Conversation

shanedell
Copy link
Contributor

@shanedell shanedell commented Dec 5, 2024 •
edited
Loading

README.md updates:

  • Add README.md to VSIX when built
  • Update the minimum required node version for building.

Closes #1108
Closes #1136

@shanedell shanedell added this to the 1.4.1 milestone Dec 5, 2024
@shanedell shanedell self-assigned this Dec 5, 2024
@shanedell shanedell changed the title Add README.md to VSIX when built README.md updates Dec 5, 2024
stevedlawrence
stevedlawrence approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@stevedlawrence stevedlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, maybe a typo?

@shanedell
README.md updates:
ae40230 
- Add README.md to VSIX when built
- Update the minimum required node version for building.

Closes apache#1108
Closes apache#1136
mbeckerle
mbeckerle approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@mbeckerle mbeckerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@shanedell shanedell merged commit 02bd451 into apache:main Dec 6, 2024
21 checks passed
@shanedell shanedell deleted the add-readme-to-vsix branch December 6, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbeckerle mbeckerle mbeckerle approved these changes

@stevedlawrence stevedlawrence stevedlawrence approved these changes

@arosien arosien Awaiting requested review from arosien

@scholarsmate scholarsmate Awaiting requested review from scholarsmate

@stricklandrbls stricklandrbls Awaiting requested review from stricklandrbls

Assignees

@shanedell shanedell

Labels
None yet
Projects
daffodil-vscode v1.4.1
Status: Done
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

README is missing from the published extension yarn package fails with node 12.22.9
3 participants
@shanedell @mbeckerle @stevedlawrence