Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn package fails with node 12.22.9 #1108

Closed
stevedlawrence opened this issue Sep 27, 2024 · 1 comment · Fixed by #1141
Closed

yarn package fails with node 12.22.9 #1108

stevedlawrence opened this issue Sep 27, 2024 · 1 comment · Fixed by #1141

Comments

@stevedlawrence
Copy link
Member

I have an Ubuntu system with node 12.22.9 installed, when I run yarn package I get this error:

error @vscode/debugadapter@1.63.0: The engine "node" is incompatible with this module. Expected version ">=14". Got "12.22.9"

If run npm install --global node@14, then I get the error

error @vscode/test-electron@2.3.8: The engine "node" is incompatible with this module. Expected version ">=16". Got "14.21.3"

Running npm install --global node@16 then yarn package succeeds.

The README says Node 10 or higher should work, and CI looks like it only tests 16. What versions of node are supported?

Also, can the node version be defined in package.json or yarn.lock, or does it have to be installed outside of that?

@shanedell
Copy link
Contributor

@stevedlawrence I believe this something we need to update in the README. In CI we are testing NodeJS 16 and 18. So we know those are supported, but technically newer versions above 16 should work but I am not 100% confident on that as sometimes newer releases can some things to break. For example, we test with NodeJS 18.20.1 because 18.20.2 seemed to cause things to break.

shanedell added a commit to shanedell/daffodil-vscode that referenced this issue Dec 5, 2024
- Add README.md to VSIX when built
- Update the minimum required node version for building.

Closes apache#1108
Closes apache#1136
shanedell added a commit to shanedell/daffodil-vscode that referenced this issue Dec 5, 2024
- Add README.md to VSIX when built
- Update the minimum required node version for building.

Closes apache#1108
Closes apache#1136
shanedell added a commit that referenced this issue Dec 6, 2024
- Add README.md to VSIX when built
- Update the minimum required node version for building.

Closes #1108
Closes #1136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants