Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [R] Fix .lintr config file for updated lintr dependency #38639

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented Nov 8, 2023

Rationale for this change

The lint CI job is failing because an update to a dependency of lintr now does more strict DCF checking on the .lintr file

What changes are included in this PR?

The 'license' field was wrapped in quotes so that .lintr passes validation

Are these changes tested?

Yes, by existing CI job

Are there any user-facing changes?

No

Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for CI

@pitrou pitrou merged commit 3d96bab into apache:main Nov 8, 2023
@pitrou pitrou removed the awaiting committer review Awaiting committer review label Nov 8, 2023
@paleolimbot paleolimbot deleted the r-minor-fix-lintr-config branch November 8, 2023 16:53
Copy link

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 3d96bab.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.

JerAguilon pushed a commit to JerAguilon/arrow that referenced this pull request Nov 9, 2023
…e#38639)

### Rationale for this change

The lint CI job is failing because an update to a dependency of lintr now does more strict DCF checking on the .lintr file

### What changes are included in this PR?

The 'license' field was wrapped in quotes so that .lintr passes validation

### Are these changes tested?

Yes, by existing CI job

### Are there any user-facing changes?

No

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…e#38639)

### Rationale for this change

The lint CI job is failing because an update to a dependency of lintr now does more strict DCF checking on the .lintr file

### What changes are included in this PR?

The 'license' field was wrapped in quotes so that .lintr passes validation

### Are these changes tested?

Yes, by existing CI job

### Are there any user-facing changes?

No

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@assignUser assignUser added this to the 14.0.2 milestone Nov 27, 2023
assignUser pushed a commit to assignUser/arrow that referenced this pull request Dec 1, 2023
…e#38639)

### Rationale for this change

The lint CI job is failing because an update to a dependency of lintr now does more strict DCF checking on the .lintr file

### What changes are included in this PR?

The 'license' field was wrapped in quotes so that .lintr passes validation

### Are these changes tested?

Yes, by existing CI job

### Are there any user-facing changes?

No

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
assignUser pushed a commit that referenced this pull request Jan 9, 2024
### Rationale for this change

The lint CI job is failing because an update to a dependency of lintr now does more strict DCF checking on the .lintr file

### What changes are included in this PR?

The 'license' field was wrapped in quotes so that .lintr passes validation

### Are these changes tested?

Yes, by existing CI job

### Are there any user-facing changes?

No

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…e#38639)

### Rationale for this change

The lint CI job is failing because an update to a dependency of lintr now does more strict DCF checking on the .lintr file

### What changes are included in this PR?

The 'license' field was wrapped in quotes so that .lintr passes validation

### Are these changes tested?

Yes, by existing CI job

### Are there any user-facing changes?

No

Authored-by: Dewey Dunnington <dewey@voltrondata.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants