-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINOR: [R] Fix .lintr config file for updated lintr dependency #38639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for CI
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 3d96bab. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…e#38639) ### Rationale for this change The lint CI job is failing because an update to a dependency of lintr now does more strict DCF checking on the .lintr file ### What changes are included in this PR? The 'license' field was wrapped in quotes so that .lintr passes validation ### Are these changes tested? Yes, by existing CI job ### Are there any user-facing changes? No Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
…e#38639) ### Rationale for this change The lint CI job is failing because an update to a dependency of lintr now does more strict DCF checking on the .lintr file ### What changes are included in this PR? The 'license' field was wrapped in quotes so that .lintr passes validation ### Are these changes tested? Yes, by existing CI job ### Are there any user-facing changes? No Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
…e#38639) ### Rationale for this change The lint CI job is failing because an update to a dependency of lintr now does more strict DCF checking on the .lintr file ### What changes are included in this PR? The 'license' field was wrapped in quotes so that .lintr passes validation ### Are these changes tested? Yes, by existing CI job ### Are there any user-facing changes? No Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
### Rationale for this change The lint CI job is failing because an update to a dependency of lintr now does more strict DCF checking on the .lintr file ### What changes are included in this PR? The 'license' field was wrapped in quotes so that .lintr passes validation ### Are these changes tested? Yes, by existing CI job ### Are there any user-facing changes? No Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
…e#38639) ### Rationale for this change The lint CI job is failing because an update to a dependency of lintr now does more strict DCF checking on the .lintr file ### What changes are included in this PR? The 'license' field was wrapped in quotes so that .lintr passes validation ### Are these changes tested? Yes, by existing CI job ### Are there any user-facing changes? No Authored-by: Dewey Dunnington <dewey@voltrondata.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Rationale for this change
The lint CI job is failing because an update to a dependency of lintr now does more strict DCF checking on the .lintr file
What changes are included in this PR?
The 'license' field was wrapped in quotes so that .lintr passes validation
Are these changes tested?
Yes, by existing CI job
Are there any user-facing changes?
No