[C++] Pin flatbuffers compiler version #35497
Comments
|
If we do this, we should first bump our vendored version of flatbuffers headers to a recent well-known changeset. |
|
cc @felipecrv |
pitrou
pushed a commit
that referenced
this issue
Oct 12, 2023
### Rationale for this change To use a more modern version of `flatc` in Arrow. ### What changes are included in this PR? 1) Re-generating the the C++ files with a `flatc` based on the latest tag on the `flatbuffer` repo. 2) Copy the minimal set of includes to our vendored folder 3) Manually re-apply the patches that have been applied to the previous headers to fix issues ### Are these changes tested? Tested by building everything correctly. * Closes: #35497 Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
llama90
pushed a commit
to llama90/arrow
that referenced
this issue
Oct 12, 2023
…pache#38192) ### Rationale for this change To use a more modern version of `flatc` in Arrow. ### What changes are included in this PR? 1) Re-generating the the C++ files with a `flatc` based on the latest tag on the `flatbuffer` repo. 2) Copy the minimal set of includes to our vendored folder 3) Manually re-apply the patches that have been applied to the previous headers to fix issues ### Are these changes tested? Tested by building everything correctly. * Closes: apache#35497 Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this issue
Oct 23, 2023
…pache#38192) ### Rationale for this change To use a more modern version of `flatc` in Arrow. ### What changes are included in this PR? 1) Re-generating the the C++ files with a `flatc` based on the latest tag on the `flatbuffer` repo. 2) Copy the minimal set of includes to our vendored folder 3) Manually re-apply the patches that have been applied to the previous headers to fix issues ### Are these changes tested? Tested by building everything correctly. * Closes: apache#35497 Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this issue
Nov 13, 2023
…pache#38192) ### Rationale for this change To use a more modern version of `flatc` in Arrow. ### What changes are included in this PR? 1) Re-generating the the C++ files with a `flatc` based on the latest tag on the `flatbuffer` repo. 2) Copy the minimal set of includes to our vendored folder 3) Manually re-apply the patches that have been applied to the previous headers to fix issues ### Are these changes tested? Tested by building everything correctly. * Closes: apache#35497 Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this issue
Feb 19, 2024
…pache#38192) ### Rationale for this change To use a more modern version of `flatc` in Arrow. ### What changes are included in this PR? 1) Re-generating the the C++ files with a `flatc` based on the latest tag on the `flatbuffer` repo. 2) Copy the minimal set of includes to our vendored folder 3) Manually re-apply the patches that have been applied to the previous headers to fix issues ### Are these changes tested? Tested by building everything correctly. * Closes: apache#35497 Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
I ran cpp/build-support/update-flatbuffers.sh and the regenerated headers included new failing static assertions like:
The probable fix is to pin the version of the flatbuffers compiler used in c++. As of google/flatbuffers#7203 the compiler inserts these static assertions which assert the version of the compiler- but our vendored flatbuffers are at 1.12.0. conda-forge has that version and after installing it I don't see failing static assertions any more.
Component(s)
C++
The text was updated successfully, but these errors were encountered: