Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyDocStyle Check - PT005: Fixture returns a value, remove leading underscore #43292

Merged
merged 2 commits into from
Oct 23, 2024
Merged

PyDocStyle Check - PT005: Fixture returns a value, remove leading underscore #43292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f50a962
style: remove underscore from function name
dannyl1u Oct 23, 2024
644dccc
style: remove PT005 from ignore list
dannyl1u Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/tests/ssh/operators/test_ssh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def setup_method(self):

# Make sure nothing in this test actually connects to SSH -- that's for hook tests.
@pytest.fixture(autouse=True)
def _patch_exec_ssh_client(self):
def patch_exec_ssh_client(self):
with mock.patch.object(self.hook, "exec_ssh_client_command") as exec_ssh_client_command:
self.exec_ssh_client_command = exec_ssh_client_command
exec_ssh_client_command.return_value = (0, b"airflow", "")
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,6 @@ ignore = [
"E731", # Do not assign a lambda expression, use a def
"TCH003", # Do not move imports from stdlib to TYPE_CHECKING block
"PT004", # Fixture does not return anything, add leading underscore
"PT005", # Fixture returns a value, remove leading underscore
"PT006", # Wrong type of names in @pytest.mark.parametrize
"PT007", # Wrong type of values in @pytest.mark.parametrize
"PT013", # silly rule prohibiting e.g. `from pytest import param`
Expand Down
Loading