Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyDocStyle Check - PT005: Fixture returns a value, remove leading underscore #43292

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

dannyl1u
Copy link
Contributor

Issue: #40567
Fix 1 remaining PT005 (Fixture returns a value, remove leading underscore) failing style check, and remove PT005 from theignore list


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk merged commit e49033d into apache:main Oct 23, 2024
58 checks passed
@potiuk
Copy link
Member

potiuk commented Oct 23, 2024

NIce!

@dannyl1u dannyl1u deleted the PyDocStyleCheck/PT005 branch October 23, 2024 15:21
harjeevanmaan pushed a commit to harjeevanmaan/airflow that referenced this pull request Oct 23, 2024
…erscore (apache#43292)

* style: remove underscore from function name

* style: remove PT005 from ignore list
PaulKobow7536 pushed a commit to PaulKobow7536/airflow that referenced this pull request Oct 24, 2024
…erscore (apache#43292)

* style: remove underscore from function name

* style: remove PT005 from ignore list
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
…erscore (apache#43292)

* style: remove underscore from function name

* style: remove PT005 from ignore list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants