Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Simplify dataset serialization code (#38089)" #38158

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Mar 14, 2024

This reverts commit c14241b.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk requested review from kaxil, XD-DENG and ashb as code owners March 14, 2024 19:04
@potiuk potiuk requested review from uranusjr and bbovenzi March 14, 2024 19:04
@potiuk
Copy link
Member Author

potiuk commented Mar 14, 2024

Reverting for now as it broke cross-merged #38123 (and apparently the serialization of dataset is not good in this case where it broke)

@potiuk potiuk merged commit 90a5cd6 into apache:main Mar 14, 2024
4 checks passed
@potiuk potiuk deleted the revert-simplify-serialization branch March 14, 2024 19:05
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants