Simplify dataset serialization code #38089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93be496 to
2c537f2
Compare
a73ca2c to
3c33733
Compare
I went back and forth a bit on this, but ultimately decided it is the most simple to just skip the entire BaseSerialization process and serialize on our own. We don't need to deserialize dataset_expression anyway (the value goes directly to the web frontend for rendering).
3c33733 to
bbb9663
Compare
eladkal
approved these changes
Mar 14, 2024
|
Reverting this one as it broke merged in-parallel #38123 |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Mar 14, 2024
This reverts commit c14241b.
potiuk
added a commit
that referenced
this pull request
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went back and forth a bit on this, but ultimately decided it is the most simple to just skip the entire BaseSerialization process and serialize on our own. We don't need to deserialize dataset_expression anyway (the value goes directly to the web frontend for rendering).