-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render list items in rendered fields view #32042
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Please address the previous review comments. #22854 (review) |
@uranusjr ok, I added the annotation to render() parameters. |
Can you setup linting locally and resolve errors please? See guide here: https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#step-4-prepare-pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll add a separate PR for refactoring out those +=
calls later
thanks @uranusjr |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
--------- Co-authored-by: clemens.valiente <clemens.valiente@grabtaxi.com> (cherry picked from commit 2b5d4e3)
This PR rebases #22854; see the original PR (#21227) for context.