Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render list items in rendered fields view #32042

Merged
merged 6 commits into from
Jul 3, 2023

Conversation

cvaliente
Copy link
Contributor

@cvaliente cvaliente commented Jun 21, 2023

This PR rebases #22854; see the original PR (#21227) for context.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Jun 21, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 21, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@uranusjr uranusjr changed the title rebase #22854 Render list items in rendered fields view Jun 21, 2023
@uranusjr
Copy link
Member

uranusjr commented Jun 21, 2023

Please address the previous review comments. #22854 (review)

@cvaliente
Copy link
Contributor Author

@uranusjr ok, I added the annotation to render() parameters.
I did not touch airflow/www/templates/airflow/ti_code.html and the out string concatenation is also untouched.

@uranusjr
Copy link
Member

Can you setup linting locally and resolve errors please? See guide here: https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#step-4-prepare-pr

airflow/www/utils.py Outdated Show resolved Hide resolved
airflow/www/utils.py Outdated Show resolved Hide resolved
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll add a separate PR for refactoring out those += calls later

@cvaliente
Copy link
Contributor Author

thanks @uranusjr
The checks now all pass, and the PR is ready to be reviewed and merged

@potiuk potiuk merged commit 2b5d4e3 into apache:main Jul 3, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 3, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@ephraimbuddy ephraimbuddy added this to the Airlfow 2.6.3 milestone Jul 6, 2023
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Jul 6, 2023
ephraimbuddy pushed a commit that referenced this pull request Jul 6, 2023
---------

Co-authored-by: clemens.valiente <clemens.valiente@grabtaxi.com>
(cherry picked from commit 2b5d4e3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants