-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow list item to be rendered instead of showing as JSON #21227
Conversation
What changed in |
Yes, they are the same. Nothing changed in BigQueryInsertJobOperator. |
I guess my question is, why are the screenshots attached if nothing changes there? |
To emphasize that the functionality from #17321 is not broken |
I see, thanks for the clarification. |
This comment was marked as resolved.
This comment was marked as resolved.
Hi, first of all thanks for the fix! What is the expected timeframe to see this one merged? |
@peloyeje I guess it will be there as soon as the author (@avkirilishin ) rebaases it and fixes the static checks that were failing. Or if the author does not do it, maybe someone (you @peloyeje ) take it over and lead it to completion. |
All right no problem will do :) |
Static checks failing - I recommend to rebasem and run pre-commit locally to test it. |
Hi @potiuk! |
880fc24
to
f49f0e7
Compare
Closed in favor of #22854 |
closes: #13988
related: #17321
related: #11177
#17321 broke a list item rendering that was introduced in #14024.
This PR fixes it again and adds some tests to avoid problems in the future.
Impact on operators:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.