Check for run_id url param when linking to graph/gantt views #29066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Jan 21, 2023
maggesssss
pushed a commit
to maggesssss/airflow
that referenced
this pull request
Jan 21, 2023
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 7, 2023
(cherry picked from commit 9dedf81)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 8, 2023
(cherry picked from commit 9dedf81)
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parts of the app linked over to the graph and gantt views with a
run_id=param, but we weren't actually using that param to decide which run to show for a user.Now, we will first check for
run_id, and only useexecution_dateifrun_idisn't specified.Fixes: #28155
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.