Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to dag graph some times display incorrect dagrun #28155

Closed
1 of 2 tasks
hterik opened this issue Dec 6, 2022 · 3 comments · Fixed by #29066
Closed
1 of 2 tasks

Links to dag graph some times display incorrect dagrun #28155

hterik opened this issue Dec 6, 2022 · 3 comments · Fixed by #29066
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:bug This is a clearly a bug

Comments

@hterik
Copy link
Contributor

hterik commented Dec 6, 2022

Apache Airflow version

2.5.0

What happened

Open url dags/gate/graph?dag_run_id=8256-8-1670328803&execution_date=2022-12-06T12%3A13%3A23.174592+00%3A00
The graph is displaying a completely different dagrun.
image
If you are not careful to review all the content, you might continue looking at the wrong results, or worse cancel a run with Mark failed.

I got the link from one of our users, so not 100% sure if it was the original url. I believe there could be something wrong with the url-encoding of the last + character. In any case, if there are any inconsistencies in the URL parameters vs the found dagruns, it should not display another dagrun, rather redirect to grid-view or error message.

What you think should happen instead

  • dag_run_id should be only required parameter, or have precedence over execution_date
  • Provided dag_run_id should always be the same run-id that is displayed in graph
  • Inconsistencies in any parameters should display error or redirect to grid view.

How to reproduce

No response

Operating System

Ubuntu 22.04

Versions of Apache Airflow Providers

No response

Deployment

Other Docker-based deployment

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@hterik hterik added area:core kind:bug This is a clearly a bug labels Dec 6, 2022
@uranusjr uranusjr added area:UI Related to UI/UX. For Frontend Developers. and removed area:core labels Dec 6, 2022
@bbovenzi
Copy link
Contributor

bbovenzi commented Dec 6, 2022

Where are you clicking the link to the graph view?

@hterik
Copy link
Contributor Author

hterik commented Dec 6, 2022

I got the link in a chat message from one of our users, he claims it was from airflow, but can not be sure if it was fat-fingered during the paste into the chat.

Regardless if the url is from a correct source or not, i still think there should be some validation to not present any arbitrary dagrun, if there is an attempt to select a dag_run_id via querystrg.

@hterik
Copy link
Contributor Author

hterik commented Jan 13, 2023

The same problem appears even when clicking links from within Airflows own UI, for example on links in the Run id column on taskinstance/list/?_flt_3_pool=default_pool&_flt_3_state=queued, instead of opening the clicked Runid, it shows some other random run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants