Update alias for field_mask in Google Memmcache #16975
Conversation
|
Needs merging otherwise any PR where setup.py is changed will break (for example #16974) due to release of new google memcache library |
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
969a0bb to
f75742e
Compare
|
seems it might be difficult-ish to make it works (I could do some conditional import) with pre and post change - but since it was non-breaking release and library used only in the memcache operators, I simply added lower bound to 1.1.0 version. |
The July 12 2021 release of google-memcache library removed field_mask alias from the library which broke our typechecking and made google provider unimportable. This PR fixes the import to use the actual import.
f75742e to
bcb4eb3
Compare
|
It's a bit worse :(, We have to
That's all because of backwards-incompatible import :( |
| 'google-cloud-memcache>=0.2.0', | ||
| # 1.1.0 removed field_mask and broke import for released providers | ||
| # We can remove the <1.1.0 limitation after we release new Google Provider | ||
| 'google-cloud-memcache>=0.2.0,<1.1.0', |
There was a problem hiding this comment.
Are you sure google-cloud-memcache v1.1.0 is compatible? These two versions were released within a short period of time.
1.1.0 (2021-06-30)
1.0.0 (2021-05-28)
There was a problem hiding this comment.
The new version may have some compatibility, but not enough for the operator to be successfully executed.
There was a problem hiding this comment.
Pretty sure 1.1.0 was released yesterday (from pypi):
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
The July 12 2021 release of google-memcache library removed field_mask alias from the library which broke our typechecking and made google provider unimportable. This PR fixes the import to use the actual import.
The July 12 2021 release of google-memcache library removed field_mask alias from the library which broke our typechecking and made google provider unimportable. This PR fixes the import to use the actual import. (cherry picked from commit a3f5c93)
The July 12 2021 release of google-memcache library removed field_mask alias from the library which broke our typechecking and made google provider unimportable. This PR fixes the import to use the actual import. (cherry picked from commit a3f5c93)
The July 12 2021 release of google-memcache library removed field_mask alias from the library which broke our typechecking and made google provider unimportable. This PR fixes the import to use the actual import. (cherry picked from commit a3f5c93)
The July 12 2021 release of google-memcache library removed field_mask alias from the library which broke our typechecking and made google provider unimportable. This PR fixes the import to use the actual import. (cherry picked from commit a3f5c93)
The July 12 2021 release of google-memcache library removed
field_mask alias from the library which broke our typechecking
and made google provider unimportable. This PR fixes the import
to use the actual import.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.