-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch back http provider after requests removes LGPL dependency #16974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following merging the psf/requests#5797 and requests 2.26.0 release without LGPL chardet dependency, we can now bring back http as pre-installed provider as it does not bring chardet automatically any more.
potiuk
force-pushed
the
bring-back-mandatory-http-provider
branch
from
July 13, 2021 18:55
c0e0b45
to
6b81adf
Compare
Seems ready to go :) |
uranusjr
approved these changes
Jul 13, 2021
github-actions
bot
added
the
full tests needed
We need to run full set of tests for this PR to merge
label
Jul 13, 2021
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
josh-fell
pushed a commit
to josh-fell/airflow
that referenced
this pull request
Jul 19, 2021
…che#16974) Following merging the psf/requests#5797 and requests 2.26.0 release without LGPL chardet dependency, we can now bring back http as pre-installed provider as it does not bring chardet automatically any more.
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 2, 2021
…che#16974) Following merging the psf/requests#5797 and requests 2.26.0 release without LGPL chardet dependency, we can now bring back http as pre-installed provider as it does not bring chardet automatically any more. (cherry picked from commit c46e841)
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 5, 2021
…che#16974) Following merging the psf/requests#5797 and requests 2.26.0 release without LGPL chardet dependency, we can now bring back http as pre-installed provider as it does not bring chardet automatically any more. (cherry picked from commit c46e841)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Aug 13, 2021
Since apache#16974 we have switched back to including HTTP provider and this comment now is not correct.
kaxil
added a commit
that referenced
this pull request
Aug 13, 2021
Since #16974 we have switched back to including HTTP provider and this comment now is not correct.
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
) Following merging the psf/requests#5797 and requests 2.26.0 release without LGPL chardet dependency, we can now bring back http as pre-installed provider as it does not bring chardet automatically any more. (cherry picked from commit c46e841)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
) Following merging the psf/requests#5797 and requests 2.26.0 release without LGPL chardet dependency, we can now bring back http as pre-installed provider as it does not bring chardet automatically any more. (cherry picked from commit c46e841)
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Mar 10, 2022
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct. GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 4, 2022
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct. GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 10, 2022
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct. GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Aug 27, 2022
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct. GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 4, 2022
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct. GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
aglipska
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 7, 2022
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct. GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Dec 7, 2022
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct. GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jan 27, 2023
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct. GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 12, 2024
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct. GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2024
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct. GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 7, 2024
Since apache/airflow#16974 we have switched back to including HTTP provider and this comment now is not correct. GitOrigin-RevId: f2a8a73ca99912d25e9cd8142038cf3a6df622d6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following merging the psf/requests#5797
and requests 2.26.0 release without LGPL chardet dependency,
we can now bring back http as pre-installed provider as it does
not bring chardet automatically any more.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.