Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GroupMembers API Pagination for Client #5533

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Support GroupMembers API Pagination for Client #5533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/apis/controlplane/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,12 @@ type GroupMember struct {
Pod *PodReference
// ExternalEntity maintains the reference to the ExternalEntity.
ExternalEntity *ExternalEntityReference
// Node maintains the reference to the Node.
Node *NodeReference
// IP is the IP address of the Endpoints associated with the GroupMember.
IPs []IPAddress
// Ports is the list NamedPort of the GroupMember.
Ports []NamedPort
// Node maintains the reference to the Node.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change not related to the PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it not related, just found the order was not consistent with type in v1beta2.

Node *NodeReference
// Service is the reference to the Service. It can only be used in an AppliedTo
// Group and only a NodePort type Service can be referred by this field.
Service *ServiceReference
Expand Down
Loading