Support GroupMembers API Pagination for Client #5533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40548ad to
82bf6f9
Compare
Dyanngg
reviewed
Sep 28, 2023
pkg/client/clientset/versioned/typed/controlplane/v1beta2/groupmembers_expansion.go
Outdated
Show resolved
Hide resolved
| // IP is the IP address of the Endpoints associated with the GroupMember. | ||
| IPs []IPAddress | ||
| // Ports is the list NamedPort of the GroupMember. | ||
| Ports []NamedPort | ||
| // Node maintains the reference to the Node. |
There was a problem hiding this comment.
change not related to the PR?
There was a problem hiding this comment.
yes it not related, just found the order was not consistent with type in v1beta2.
tnqn
reviewed
Oct 11, 2023
|
|
||
| func convertToV1beta2Members(members []controlplane.GroupMember) []v1beta2.GroupMember { | ||
| var result []v1beta2.GroupMember | ||
| for _, item := range members { |
There was a problem hiding this comment.
Can we use Schema.Convert to do the conversion for code reuse?
There was a problem hiding this comment.
Changed to conversion function in v1beta2.
|
|
||
| func convertToControlplaneMembers(members []v1beta2.GroupMember) []controlplane.GroupMember { | ||
| var result []controlplane.GroupMember | ||
| for _, item := range members { |
| @@ -489,17 +489,7 @@ func RegisterConversions(s *runtime.Scheme) error { | |||
|
|
|||
| func autoConvert_v1beta2_AddressGroup_To_controlplane_AddressGroup(in *AddressGroup, out *controlplane.AddressGroup, s conversion.Scope) error { | |||
| out.ObjectMeta = in.ObjectMeta | |||
| if in.GroupMembers != nil { | |||
There was a problem hiding this comment.
Is this caused by the move of Node *NodeReference?
There was a problem hiding this comment.
I think so, it's generated code, surprised to see this shortened conversion.
29357d7 to
09ee5e6
Compare
Follow up for Group membership API to provide paginated Get function for client. Signed-off-by: Qiyue Yao <yaoq@vmware.com>
09ee5e6 to
84dc488
Compare
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GroupMembers API was introduced in #5380 , pagination was supported for proxy server, but not for client. There are usecases for client-go pagination. This solution utilizes the
GroupMembersExpansionto provide a new methodGetPaginated.