Automated cherry pick of #4064: Fix NetworkPolicy tests on Clouds #4498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release-1.7 #4498 +/- ##
===============================================
- Coverage 63.41% 62.90% -0.52%
===============================================
Files 299 299
Lines 44478 44478
===============================================
- Hits 28206 27979 -227
- Misses 14022 14302 +280
+ Partials 2250 2197 -53
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
This PR is stale because it has been open 90 days with no activity. Remove stale label or comment, or this will be closed in 90 days |
GKE's cluster version now defaults to v1.24.1, which no longer creates secret for service account automatically, the verification in old test cases would fail. This patch makes the test determine conformance container image version based on the cluster's version to avoid such issue. However, the test suite Netpol introduced in new conformance image uses a Namespace creation function which is not robust, leanding to random test failures in GKE test. This patch skips it temporarily. Besides, legacy NetworkPolicy tests for AKS and EKS have been skipped by mistake for a while because of a conflicting skip regex. This patch fixes it. For antrea-io#3762 Signed-off-by: Quan Tian <qtian@vmware.com>
6cd3387 to
d480d06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #4064 on release-1.7.
#4064: Fix NetworkPolicy tests on Clouds
For details on the cherry pick process, see the cherry pick requests page.