[CI] Fix NetworkPolicy tests on Clouds #4064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4064 +/- ##
==========================================
+ Coverage 64.24% 67.54% +3.29%
==========================================
Files 294 297 +3
Lines 44809 45034 +225
==========================================
+ Hits 28787 30416 +1629
+ Misses 13671 12240 -1431
- Partials 2351 2378 +27
|
tnqn
commented
Jul 29, 2022
ci/test-conformance-aks.sh
Outdated
| @@ -247,7 +247,7 @@ function run_conformance() { | |||
| echo "=== Running Antrea Conformance and Network Policy Tests ===" | |||
| # Skip NodePort related cases for AKS since as Nodes in AKS cluster seem not accessible from other Nodes | |||
| # through public IPs by default. See https://github.com/antrea-io/antrea/issues/2409 | |||
| skip_regex="\[Slow\]|\[Serial\]|\[Disruptive\]|\[Flaky\]|\[Feature:.+\]|\[sig-cli\]|\[sig-storage\]|\[sig-auth\]|\[sig-api-machinery\]|\[sig-apps\]|\[sig-node\]|NodePort" | |||
| skip_regex="\[Slow\]|\[Serial\]|\[Disruptive\]|\[Flaky\]|\[Feature:(?!NetworkPolicy\])|\[sig-cli\]|\[sig-storage\]|\[sig-auth\]|\[sig-api-machinery\]|\[sig-apps\]|\[sig-node\]|\[sig-instrumentation\]|NodePort" | |||
There was a problem hiding this comment.
Unfortunately this doesn't work:
ERRO[0000] invalid argument "\\[Feature:(?!NetworkPolicy\\])" for "--e2e-skip" flag: flag value "\\[Feature:(?!NetworkPolicy\\])" fails regexp validation: error parsing regexp: invalid or unsupported Perl syntax: `(?!`
antoninbas
previously approved these changes
Aug 8, 2022
GKE's cluster version now defaults to v1.24.1, which no longer creates secret for service account automatically, the verification in old test cases would fail. This patch makes the test determine conformance container image version based on the cluster's version to avoid such issue. However, the test suite Netpol introduced in new conformance image uses a Namespace creation function which is not robust, leanding to random test failures in GKE test. This patch skips it temporarily. Besides, legacy NetworkPolicy tests for AKS and EKS have been skipped by mistake for a while because of a conflicting skip regex. This patch fixes it. For antrea-io#3762 Signed-off-by: Quan Tian <qtian@vmware.com>
Yes, the latest patch updated to run legacy NetworkPolicy tests only for all 3 clouds because AKS also seems unable to run it due to some issues: https://jenkins.antrea-ci.rocks/view/cloud/job/cloud-antrea-aks-conformance-net-policy/287/. I think it's perhaps better to wait for NetPol being more reliable before running it on any cloud. |
antoninbas
approved these changes
Aug 9, 2022
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GKE's cluster version now defaults to v1.24.1, which no longer creates
secret for service account automatically, the verification in old test
cases would fail. This patch makes the test determine conformance
container image version based on the cluster's version to avoid such
issue.
However, the test suite Netpol introduced in new conformance image uses
a Namespace creation function which is not robust, leanding to random
test failures in GKE test. This patch skips it temporarily.
Besides, legacy NetworkPolicy tests for AKS and EKS have been skipped
by mistake for a while because of a conflicting skip regex. This patch
fixes it.
For #3762
Signed-off-by: Quan Tian qtian@vmware.com