Add SSL checking function in windows OVS script #4029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4029 +/- ##
==========================================
+ Coverage 60.62% 64.22% +3.60%
==========================================
Files 296 293 -3
Lines 43864 43686 -178
==========================================
+ Hits 26592 28057 +1465
+ Misses 15080 13348 -1732
- Partials 2192 2281 +89
|
wenyingd
reviewed
Jul 19, 2022
hack/windows/Install-OVS.ps1
Outdated
| } | ||
| } | ||
| $SSLZip = "openssl-1.0.2u-x64_86-win64.zip" | ||
| curl.exe -LO https://indy.fulgan.com/SSL/$SSLZip |
There was a problem hiding this comment.
Add check on the curl result before trying to unzip it?
hack/windows/Install-OVS.ps1
Outdated
| @@ -199,6 +199,22 @@ function InstallOVS() { | |||
| SetEnvVar "Path" $env:Path | |||
| } | |||
|
|
|||
| function CheckIfLibInstalled() { | |||
There was a problem hiding this comment.
Rename it as "InstallDependency"?
wenyingd
reviewed
Jul 21, 2022
| $SSLDownloadURL = "https://indy.fulgan.com/SSL/$SSLZip" | ||
| curl.exe -LO $SSLDownloadURL | ||
| If (!$?) { | ||
| Log "Download SSL files failed, URL: $SSLDownloadURL" |
There was a problem hiding this comment.
Add a reminder to let user manual install the dependent dll files, and we should list the exact name of the two dependent files.?
0c74166 to
3bd5741
Compare
tnqn
reviewed
Jul 22, 2022
|
s/ |
Windows OVS needs SSL files to start service. Add new funtion in Install-OVS.ps1 to check files exist and install SSL library if files don't exist. Fixes antrea-io#4027 Signed-off-by: Shuyang Xin <gavinx@vmware.com> Co-authored-by: wenyingd <wenyingd@vmware.com>
|
/skip-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows OVS needs SSL files to start service.
Add new funtion in Install-OVS.ps1 to check files exist and install
SSL library if files don't exist.
Fixes #4027
Signed-off-by: Shuyang Xin gavinx@vmware.com
Co-authored-by: wenyingd wenyingd@vmware.com