[PoC] Modify materialize overload of Result<T, NSError> to be buildable on both Swift 3.0 and 3.1
#214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ldable on both Swift 3.0 and 3.1
mdiep
reviewed
Mar 2, 2017
.travis.yml
Outdated
| @@ -29,5 +29,10 @@ matrix: | |||
| language: generic | |||
| install: | |||
| - eval "$(curl -sL https://gist.githubusercontent.com/kylef/5c0475ff02b7c7671d2a/raw/9f442512a46d7a2af7b850d65a7e9bd31edfb09b/swiftenv-install.sh)" | |||
| - script: | |||
| - docker run -v `pwd`:`pwd` -w `pwd` norionomura/swift:3120170205a swift test | |||
There was a problem hiding this comment.
This deserves a comment as I'm not really sure what it's doing.
There was a problem hiding this comment.
Replaced it with a recent 3.1-DEVELOPMENT-SNAPSHOT on Linux: b26e951
| let userInfo = _swift_Foundation_getErrorDefaultUserInfo(error) as? [String: Any] | ||
| let nsError = NSError(domain: error._domain, code: error._code, userInfo: userInfo) | ||
| return .failure(nsError) | ||
| #endif |
There was a problem hiding this comment.
I think this is acceptable, but would prefer to see a comment that says something like "This isn't great, but it lets us maintain compatibility until this deprecated method can be removed."
8ee52de to
939c0f3
Compare
mdiep
approved these changes
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to address #212 (see also #213). This does not require major version bump so make it easy to upgrade to Swift 3.1. But I'm not confident if this is acceptable.