Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed on Linux with swift 3.1 #212

Closed
KelvinJin opened this issue Feb 7, 2017 · 6 comments
Closed

Build failed on Linux with swift 3.1 #212

KelvinJin opened this issue Feb 7, 2017 · 6 comments

Comments

@KelvinJin
Copy link

Sorry to bother you guys with the pre-released swift version. I just want you to know this issue.

The issue was reported here. And the apple guys confirmed the issue is intended behaviour. The related code is here.

This actually won't be an issue once we remove these deprecated methods.

@KelvinJin KelvinJin changed the title build failed on Linux with swift 3.1 Build failed on Linux with swift 3.1 Feb 7, 2017
@norio-nomura
Copy link
Contributor

I know the issue and fix is here. 011a8c9
Could you please try swift package edit Result --revision nn-swift-3.1-on-linux in your project directory before running swift build for confirming fixed by that?

@KelvinJin
Copy link
Author

@norio-nomura Oh, didn't know you fix it! That's cool. So I guess instead of fatal error, should we just remove these two methods?

@norio-nomura
Copy link
Contributor

I can not believe that all users have already completed the transition.

@KelvinJin
Copy link
Author

@norio-nomura oh, no. I'm not saying we release it now. Sure we'll wait for Swift 3.1 official release. But when it comes out, instead of just crash the app, we should probably force them to update? It's entirely up to you guys. I'm a happy user as long as this can be built :))))

@norio-nomura
Copy link
Contributor

Ah, we should change them from deprecated to unavailable.

@ikesyo
Copy link
Member

ikesyo commented Mar 4, 2017

This should have been fixed in 3.2.1 release. Please check it out! 🙏

@ikesyo ikesyo closed this as completed Mar 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants