[1.0-beta2 -> main] P2P: Send handshake when in lib_catchup and verify catchup is called #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d. Should avoid peer thinking the peer is still syncing from it.
[1.0-beta2] P2P: Send handshake when in lib_catchup and verify catchup is called
…ib-advance-main
greg7mdp
approved these changes
Jun 6, 2024
linh2931
approved these changes
Jun 6, 2024
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of ignoring a verify catchup while in
lib_catchup, send handshake to peer. Should avoid the peer thinking it is still syncing from it.Merges
release/1.0-beta2intomainincluding #241Resolves #224