Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0-beta2] P2P: Send handshake when in lib_catchup and verify catchup is called #241

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

heifner
Copy link
Member

@heifner heifner commented Jun 5, 2024

Instead of ignoring a verify catchup while in lib_catchup, send handshake to peer. Should avoid the peer thinking it is still syncing from it.

Resolves #224

…d. Should avoid peer thinking the peer is still syncing from it.
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: INTERNALS
summary: Shorten block syncing time, by sending handshake in lib_catchup and verify catchup is called.
Note:end

@heifner heifner added the OCI Work exclusive to OCI team label Jun 6, 2024
@heifner heifner requested a review from linh2931 June 6, 2024 11:04
@heifner heifner linked an issue Jun 6, 2024 that may be closed by this pull request
@heifner heifner merged commit 6f1fb73 into release/1.0-beta2 Jun 6, 2024
36 checks passed
@heifner heifner deleted the GH-224-lib-advance-beta2 branch June 6, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI Work exclusive to OCI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: lib_advance_test
4 participants