Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure: lib_advance_test #224

Closed
heifner opened this issue Jun 3, 2024 · 1 comment · Fixed by #241 or #249
Closed

Test failure: lib_advance_test #224

heifner opened this issue Jun 3, 2024 · 1 comment · Fixed by #241 or #249
Assignees
@heifner
Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Milestone
Savanna: Beta 2.x

Comments

@heifner
Copy link
Member

heifner commented Jun 3, 2024

https://github.com/AntelopeIO/spring/actions/runs/9353204320/job/25743769240

  File "/__w/spring/spring/build/tests/lib_advance_test.py", line 131, in <module>
    assert prodD.waitForLibToAdvance()

It is stuck thinking the peer it needs blocks from is syncing from it. I believe we need to send a handshake when verify_catchup is in lib_catchup. Currently it just silently returns and no other progress is made.

spring/plugins/net_plugin/net_plugin.cpp

Line 2396 in 5cb6020

if( sync_state == lib_catchup || num < chain_info.lib_num )

@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jun 3, 2024
@arhag arhag added bug The product is not working as was intended. 👍 lgtm and removed triage labels Jun 3, 2024
@arhag arhag added this to the Savanna: Production-Ready milestone Jun 3, 2024
@arhag
Copy link
Member

arhag commented Jun 3, 2024

Does not need to be a blocker for Spring 1.0 stable, but should be an easy 1-line fix.

@arhag arhag assigned heifner and unassigned heifner Jun 4, 2024
@heifner heifner self-assigned this Jun 5, 2024
@heifner heifner added OCI Work exclusive to OCI team labels Jun 5, 2024
heifner added a commit that referenced this issue Jun 5, 2024
@heifner
GH-224 Send handshake when in lib_catchup and verify catchup is calle…
a1d4ecc 
…d. Should avoid peer thinking the peer is still syncing from it.
@heifner heifner moved this from Todo to In Progress in Team Backlog Jun 5, 2024
@heifner heifner mentioned this issue Jun 5, 2024
Merged
@heifner heifner linked a pull request Jun 6, 2024 that will close this issue
[1.0-beta2] P2P: Send handshake when in lib_catchup and verify catchup is called #241
Merged
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Jun 6, 2024
heifner added a commit that referenced this issue Jun 6, 2024
@heifner
Merge branch 'release/1.0-beta2' into GH-224-lib-advance-beta2
a5f72d1
heifner added a commit that referenced this issue Jun 6, 2024
@heifner
Merge pull request #241 from AntelopeIO/GH-224-lib-advance-beta2
6f1fb73 
[1.0-beta2] P2P: Send handshake when in lib_catchup and verify catchup is called
heifner added a commit that referenced this issue Jun 6, 2024
@heifner
Merge remote-tracking branch 'spring/release/1.0-beta2' into GH-224-l…
8e41c8d 
…ib-advance-main
@heifner heifner mentioned this issue Jun 6, 2024
Merged
heifner added a commit that referenced this issue Jun 7, 2024
@heifner
Merge pull request #249 from AntelopeIO/GH-224-lib-advance-main
1c60b88 
[1.0-beta2 -> main] P2P: Send handshake when in lib_catchup and verify catchup is called
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Savanna: Beta 2.x
3 participants
@heifner @arhag @enf-ci-bot