Circuit Refactoring #612
Merged
Circuit Refactoring #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added connect_components_in_parallel and connect_components_in_series methods
added connect_components_in_parallel and connect_components_in_series methods
MaxJPRey
reviewed
Nov 30, 2021
added connect_components_in_parallel and connect_components_in_series methods Added net property to pins
…ps' into Enhancement/connect_multiple_comps
added connect_components_in_parallel and connect_components_in_series methods Added net property to pins
added connect_components_in_parallel and connect_components_in_series methods Added net property to pins
Fixed create_touchsthone_component
MaxJPRey
reviewed
Dec 2, 2021
MaxJPRey
reviewed
Dec 2, 2021
Alberto-DM
approved these changes
Dec 2, 2021
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com> Co-authored-by: Alberto-DM <84965833+Alberto-DM@users.noreply.github.com>
MaxJPRey
approved these changes
Dec 2, 2021
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added connect_components_in_parallel and connect_components_in_series methods