Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Select "user specified settings" setting more reliably #5275

Merged
merged 9 commits into from
Oct 14, 2024
Merged

FIX: Select "user specified settings" setting more reliably #5275

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3b2d6b8
fix: select user specified settings more reliably
lorenzovecchietti Oct 10, 2024
70e817a
Merge branch 'main' into fix/issue-5263
lorenzovecchietti Oct 10, 2024
f353c7b
apply codacity suggestion
lorenzovecchietti Oct 11, 2024
a958757
Merge remote-tracking branch 'origin/fix/issue-5263' into fix/issue-5263
lorenzovecchietti Oct 11, 2024
b1c514e
Merge branch 'main' into fix/issue-5263
lorenzovecchietti Oct 11, 2024
cde6c0b
Update src/ansys/aedt/core/modules/mesh_icepak.py
lorenzovecchietti Oct 14, 2024
0067519
Update src/ansys/aedt/core/modules/mesh_icepak.py
lorenzovecchietti Oct 14, 2024
d6bb076
Merge branch 'main' into fix/issue-5263
lorenzovecchietti Oct 14, 2024
8c7af07
FIX: syntax error
lorenzovecchietti Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/ansys/aedt/core/modules/mesh_icepak.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,12 +509,9 @@ def parse_settings_as_args(self):
for k, v in self._instance_settings.items():
out.append(k + ":=")
if k in ["MaxElementSizeX", "MaxElementSizeY", "MaxElementSizeZ", "MinGapX", "MinGapY", "MinGapZ"]:
v = _dim_arg(v, getattr(self._mesh_class, "_model_units"))
v = _dim_arg(v, self._mesh_class._model_units)
out.append(v)
out.append(
"UserSpecifiedSettings:=",
)
out.append("MeshRegionResolution" in self.keys())
out += ["UserSpecifiedSettings:=", self._mesh_class.manual_settings]
return out

def parse_settings_as_dictionary(self):
Expand Down Expand Up @@ -1198,7 +1195,7 @@ def assign_mesh_level(self, mesh_order, name=None):
"""
level_order = {}
for obj in mesh_order:
if mesh_order[obj] not in level_order.keys():
if mesh_order[obj] not in level_order:
level_order[mesh_order[obj]] = []
level_order[mesh_order[obj]].append(obj)
list_meshops = []
Expand Down
Loading