Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Select "user specified settings" setting more reliably #5275

Merged
merged 9 commits into from
Oct 14, 2024

Conversation

lorenzovecchietti
Copy link
Contributor

Close #5263

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Oct 10, 2024
@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review October 11, 2024 07:36
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.26%. Comparing base (7e793f9) to head (8c7af07).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5275   +/-   ##
=======================================
  Coverage   83.26%   83.26%           
=======================================
  Files         143      143           
  Lines       58471    58470    -1     
=======================================
+ Hits        48683    48686    +3     
+ Misses       9788     9784    -4     

SMoraisAnsys
SMoraisAnsys previously approved these changes Oct 12, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a minor comment. Can't we directly access the attributes instead of using getattr ? It would make sense if we provided a default value in cases where self._mesh_class does not have the attribute, but we are not leveraging that here.

src/ansys/aedt/core/modules/mesh_icepak.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/mesh_icepak.py Outdated Show resolved Hide resolved
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@lorenzovecchietti lorenzovecchietti enabled auto-merge (squash) October 14, 2024 07:36
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@lorenzovecchietti Sry for the typo in my previous change proposition !

@lorenzovecchietti lorenzovecchietti merged commit 120f6e5 into main Oct 14, 2024
40 checks passed
@lorenzovecchietti lorenzovecchietti deleted the fix/issue-5263 branch October 14, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icepak. Bug in manual mesh setting with icepak.mesh.global_mesh_setting
2 participants