-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Select "user specified settings" setting more reliably #5275
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5275 +/- ##
=======================================
Coverage 83.26% 83.26%
=======================================
Files 143 143
Lines 58471 58470 -1
=======================================
+ Hits 48683 48686 +3
+ Misses 9788 9784 -4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left a minor comment. Can't we directly access the attributes instead of using getattr
? It would make sense if we provided a default value in cases where self._mesh_class
does not have the attribute, but we are not leveraging that here.
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lorenzovecchietti Sry for the typo in my previous change proposition !
Close #5263