Use ansible-runner in APB Base #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmontleon
requested changes
Jul 9, 2018
| @@ -1,4 +1,4 @@ | |||
| FROM centos:7 | |||
| FROM ansible/ansible-runner:latest | |||
There was a problem hiding this comment.
Since they don't have an rpm based container upstream maybe we can install ansible-runner from EPEL instead.
There was a problem hiding this comment.
I don't get the impression they are keeping the RPM up to date. I feel like the best way to stay up-to-date is with the container image but I can make the change if that's best.
bash-4.2# yum -y install python-ansible-runner
bash-4.2# rpm -qa | grep 'ansible-runner'
python2-ansible-runner-1.0.1-1.el7.noarch
Declare /opt/apb/env dir in files
|
Tested with and without RPM install |
|
ACK! |
jmontleon
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates apb-base to be based off
ansible/ansible-runner.