-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to get execution environments factories working #8126
Changes to get execution environments factories working #8126
Conversation
@@ -19,6 +20,29 @@ class ExecutionEnvironment(HasCreate, base.Base): | |||
dependencies = [Organization, Credential] | |||
NATURAL_KEY = ('organization', 'image') | |||
|
|||
# fields are image, organization, managed_by_tower, credential | |||
def create(self, image='quay.io/ansible/ansible-runner:devel', credential=None, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this truly what we want for the default image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't the AWX default image. That will include some content that we already provide in the Ansible venv. For that, I've built https://quay.io/repository/alancoding/awx-ee?tab=info, which needs to be rebuilt, and an official image is still TBD.
No matter what kind of thing you're making, there is no viable pathway to making a working image unless you use the ansible-runner Dockerfile. Because if you don't use that, it won't work with ansible-runner, and thus not work with AWX in any way, shape, or form.
Out of the images that are built from this Dockerfile, you may consider https://hub.docker.com/r/ansible/ansible-runner or https://quay.io/repository/ansible/ansible-runner. Out of these two, only the quay.io one is built continuously on an automated trigger. The Dockerhub one is effectively already out-of-date and non-functional.
But for making a custom execution environment, you don't want the AWX default execution environment that has azure.azcollection
in it, because that's probably not necessary for whatever minor thing it is you're trying to verify in a test. If you want the minimum thing that basically works, that's the quay.io ansible-runner image... for now.
No description provided.