-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AWX support for a data model and APIs to represent and manage Execution Environments #7064
Comments
Additionally, we'll want to support this in our various SDK/CLI toolkit i.e., adding support creating and associating these in both the AWX collection and CLI. |
UI work for execution environments:
|
Note that I've been convinced that having separate name and image url fields is redundant, so I've reduced it to a single field called |
Additional items and potential items that were left out of PR #7455
cc @shanemcd |
Just mentioning it here, there's currently no |
Most of those look good, a few questions:
What does this mean? I thought the user is expected to use an image registry. Yes, there is some time required to download the images on a new machine (somewhat similar to how project syncs work), and timeout in some tests have to be relaxed for this reason, particularly as image size grows. But I don't know where you're going with this idea of bundled EEs. I don't know of any remaining work that looks quite like that.
What does this mean? A single unified job should have exactly 1 EE associated with it, similar to instance & instance group & custom virtualenv. |
Sure, but the reverse is not true. Any given EE will wind up with many jobs that were run using it. To be clear, I'm squishy as to whether this is an actually useful API endpoint, which is why I kicked the can down the road. |
There is supposed to be an EE model instance that will be associated with and installed by any given version of AWX, that will have the reference to the image in the registry that is the expected default container EE that will be used. |
Oh right, carry on. Something like
I want to know a little more about the reasons here. @kdelee has done a lot to try and clarification expectations for the image version. Yes, we need to produce tags specific to AWX version, so you might have Just a little bit above you mentioned:
If we have this, why would we need an EE model instance for the same thing? Even if you need to pin the exact version, you already have the current AWX version, so you could just append that onto the default value, defined in Line 67 in c72d55f
Let's say the default image gets named AWX_EXECUTION_ENVIRONMENT_DEFAULT_IMAGE = 'quay.io/ansible/awx-default-execution-environment:' + get_awx_version() And again, I don't even know if you need to do that, because we can just make |
Closed due to extensive testing from @elyezer @yagomarques and @shebangbash , any follow up will be tracked in new issues |
This is a subtask of a larger enhancement/initiative surrounding execution environments: #5157
Implement APIs for defining execution environment and their sources (registries).
quay.io/redhat/someimage:latest
This work will be consumed by #7060
The text was updated successfully, but these errors were encountered: