Changes settings revert all to send DELETE on individual endpoint rather than PATCHing

[mabashian]

SUMMARY

Resolves #3831

#3831 (comment) is a good explanation of the state of the new UI as well as the old. The Misc System settings were the most problematic part of this since that form pulled fields from both /api/v2/settings/system and /api/v2/settings/authentication. In order to revert these fields with a DELETE request I needed to split this form up into Miscellaneous System and Miscellaneous Authentication. The Activity Stream Settings also needed to be absorbed by the Miscellaneous System Settings.

All settings forms (except noted below) will now issue a DELETE request to revert all the fields for a particular settings subsection.

There was one form that I did not change the Revert All functionality on and that was the LDAP Settings form(s). The UI splits these fields out into 5 different subforms and reverting one (issuing a DELETE on /api/v2/settings/ldap) would revert all the ldap settings which I think is undesirable.

This fix has the added benefit of cleaning up future activity stream entries for reverting an entire settings category.

I also consulted with @wenottingham and @gamuniz on some fields that were present in the api but missing in the ui and I added those.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

• UI

[softwarefactory-project-zuul]

Build succeeded.

• awx-api-lint : SUCCESS in 3m 33s
• awx-api : SUCCESS in 6m 02s
• awx-ui : SUCCESS in 15m 19s
• awx-swagger : SUCCESS in 6m 36s
• awx-detect-schema-change : SUCCESS in 6m 35s (non-voting)
• awx-ansible-modules : SUCCESS in 4m 26s

[AlanCoding]

I checked out this branch and poked around. Starting out I mucked with the jobs settings. Changing some, then reverting all.

This looks nice. I think there are good reasons to go with this.

The one qualifier I want to make here is that the PATCH will include all settings in the category ("jobs" category here). This leads to "creation" entries like this:

The default value of the "Default Project Update Timeout" is 0. So this is a junk entry. I do feel opinionated that we should address this. However, I think the proper place for the fix is API-side. I think we can get by without it for now, but we should file and issue for that if this merges.

Confirmed that LDAP categories behave like they always have. Those should be pretty stable and I'm not too worried about it.

I looked over the activity stream after mucking with some settings categories. There are a lot of entries, due to the default value issue I mentioned. Also, the deletion issues are pretty ugly, due to an open issue, #10360

[AlanCoding]

(you should get UI reviews too, I'm just considering the requests being made)

[tiagodread]

We are now making DELETE requests for all settings subforms properly and these events are being displayed as deleted in the activity stream.

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).

• awx-api-lint : SUCCESS in 2m 54s
• awx-api : SUCCESS in 6m 22s
• awx-ui : SUCCESS in 12m 21s
• awx-swagger : SUCCESS in 7m 01s
• awx-detect-schema-change : SUCCESS in 6m 31s (non-voting)
• awx-ansible-modules : SUCCESS in 2m 18s
• awx-push-new-schema : SUCCESS in 7m 07s (non-voting)