Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATCH to settings endpoint with default value shouldn't generate activity stream entry #10408

Open
AlanCoding opened this issue Jun 10, 2021 · 0 comments

Comments

@AlanCoding
Copy link
Member

ISSUE TYPE
  • Bug Report
SUMMARY

Settings operations generate a lot of useless noise when given their own default values.

STEPS TO REPRODUCE

PATCH to /api/v2/settings/all/ with a payload like {"SOME_SETTING": "value"} where the value is the system default of that setting, starting from the state after all settings have been reset to defaults.

EXPECTED RESULTS

Nothing changes, so there should be nothing in the activity stream about this

ACTUAL RESULTS

It "creates" the setting according to the activity stream

ADDITIONAL INFORMATION

This produces a lot of noise with how the UI operates specifically, followup from #10376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants