Introduce distinct controlplane instance group #10324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
56732d0 to
a27bac0
Compare
|
Build failed.
|
a27bac0 to
e4bf60e
Compare
|
Build succeeded.
|
e4bf60e to
56ea369
Compare
|
Build succeeded.
|
56ea369 to
ec8ac6f
Compare
Spredzy
added a commit
to Spredzy/awx-operator
that referenced
this pull request
Jun 7, 2021
Spredzy
added a commit
to Spredzy/awx-operator
that referenced
this pull request
Jun 7, 2021
Spredzy
added a commit
to Spredzy/awx-operator
that referenced
this pull request
Jun 7, 2021
Spredzy
added a commit
to Spredzy/awx-operator
that referenced
this pull request
Jun 7, 2021
Spredzy
added a commit
to Spredzy/awx-operator
that referenced
this pull request
Jun 7, 2021
|
Build succeeded.
|
|
Build failed.
|
81b0e7d to
023cc68
Compare
|
Build succeeded.
|
AlanCoding
reviewed
Jun 8, 2021
| register( | ||
| 'DEFAULT_CONTROL_PLANE_QUEUE_NAME', | ||
| field_class=fields.CharField, | ||
| label=_('The instance group where control plane tasks run'), |
There was a problem hiding this comment.
The name of the instance group where control plane tasks run?
The default EE uses a ForeignKey instead of name, this isn't consistent. We've never had settings reference objects before, which is why we're facing it with this release cycle.
If the user changes the value, what is the expected behavior? It won't create a new instance group with that name right? So would they have to make a corresponding change to their installer (or installer variables)?
There was a problem hiding this comment.
Did you miss the read_only=True part?
matburt
approved these changes
Jun 8, 2021
Spredzy
approved these changes
Jun 8, 2021
beeankha
approved these changes
Jun 8, 2021
|
Build succeeded (gate pipeline).
|
softwarefactory-project-zuul bot
added a commit
that referenced
this pull request
Jun 17, 2021
Update and expand docs/ folder for EEs This has some new content about EE precedence, which I don't think we've documented anywhere else, thinking of @tvo318 here, content was developed by @jbradberry (I think the numbers 2 and 3 in the global job default EE may still be subject to revision, just a warning) @shanemcd #10324 is incorporated into this This mentions @rebeccahhh's venv migration stuff, but I'm trying to write the absolute minimum possible while still mentioning migration. Reviewed-by: Rebeccah Hunter <rhunter@redhat.com> Reviewed-by: Alan Rominger <arominge@redhat.com> Reviewed-by: Jeff Bradberry <None>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.