Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define a DEFAULT_QUEUE_NAME #10208

Closed
wants to merge 1 commit into from
Closed

Define a DEFAULT_QUEUE_NAME #10208

wants to merge 1 commit into from

Conversation

Spredzy
Copy link
Contributor

@Spredzy Spredzy commented May 17, 2021

No description provided.

@Spredzy Spredzy requested a review from shanemcd May 17, 2021 16:06
@Spredzy Spredzy marked this pull request as draft May 17, 2021 16:06
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@Spredzy Spredzy force-pushed the default_queue_name branch from 7610ff4 to 0b06515 Compare May 18, 2021 09:11
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@Spredzy Spredzy force-pushed the default_queue_name branch from 0b06515 to e19b02b Compare May 18, 2021 09:32
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@Spredzy Spredzy force-pushed the default_queue_name branch 2 times, most recently from 4460e19 to ffa074a Compare May 18, 2021 10:04
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@Spredzy
Copy link
Contributor Author

Spredzy commented May 18, 2021

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@Spredzy Spredzy force-pushed the default_queue_name branch from ffa074a to d26feae Compare May 18, 2021 12:47
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@Spredzy Spredzy force-pushed the default_queue_name branch from d26feae to ab7811f Compare May 18, 2021 14:09
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@Spredzy Spredzy changed the title [WIP] Define a DEFAULT_QUEUE_NAME Define a DEFAULT_QUEUE_NAME May 18, 2021
rooftopcellist
rooftopcellist approved these changes May 18, 2021
View reviewed changes
Copy link
Member

@rooftopcellist rooftopcellist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shanemcd
Copy link
Member

shanemcd commented Jun 1, 2021

This will most likely be replaced by #10324

@Spredzy
Copy link
Contributor Author

Spredzy commented Jun 3, 2021

Closing in favor of prev mentionned PR

@Spredzy Spredzy closed this Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rooftopcellist rooftopcellist rooftopcellist approved these changes

@beeankha beeankha beeankha approved these changes

@shanemcd shanemcd Awaiting requested review from shanemcd

Assignees
No one assigned
Labels
component:api type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Spredzy @shanemcd @rooftopcellist @beeankha @AlanCoding