Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo changes to the Ansible collection inclusion requirements that were not voted on by the Steering Committee #62

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

felixfontein
Copy link
Collaborator

These changes were made in ansible/ansible@090a5cd.

These sections really have to be updated, but this must not be done without approval by the Ansible Community Steering Committe. I'm reverting them so we can start with the currently approved version.

CC @samccann @s-hertel @mattclay

Also CC @gotmax23 @mariolenz

@gotmax23
Copy link
Collaborator

gotmax23 commented Jul 8, 2023

Would it be better to start a vote on whether to keep it?

@felixfontein
Copy link
Collaborator Author

I think it's better to start again with the new version as a proposal, and see whether we want to keep it as-is, slightly adjust it, or completely replace it by something else. For example the Python 2.7 part in the controller environment should be removed IMO, same as the Python 3.5 part, since the current stable ansible-core release does not support either of them. Same for Python 2.6 and 3.5 on the target side.

@felixfontein
Copy link
Collaborator Author

CC @ansible/steering-committee @russoz @markuman @jamescassell @briantist

Copy link
Contributor

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gundalow gundalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed to revert then put the change via the normal review/vote process

@felixfontein felixfontein merged commit 0b89a6a into ansible:devel Jul 10, 2023
@felixfontein felixfontein deleted the undo-changes branch July 10, 2023 20:15
@felixfontein
Copy link
Collaborator Author

Thanks everyone. I'll create a new PR with the (reverted) changes and a discussion topic.

@felixfontein
Copy link
Collaborator Author

#68 is a draft PR with the reverted change, and ansible-community/community-topics#251 the corresponding discussion topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants