Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snap: detect change by checking final state #7340

Merged
merged 3 commits into from
Oct 8, 2023
Merged

snap: detect change by checking final state #7340

merged 3 commits into from
Oct 8, 2023

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Oct 2, 2023 •
edited
Loading

SUMMARY

Change the change detection mechanism from "parsing installation" to "comparing end state with initial state".

Fixes #7265

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

snap

ADDITIONAL INFORMATION

@ansibullbot
Copy link
Collaborator

cc @angristan @vcarceler
click here for bot help

@ansibullbot ansibullbot added module module plugins plugin (any type) tests tests unit tests/unit labels Oct 2, 2023
@russoz russoz changed the title snap: detect change by checking final state [WIP] snap: detect change by checking final state Oct 2, 2023
@russoz russoz mentioned this pull request Oct 2, 2023
Closed
1 task
@ansibullbot ansibullbot added WIP Work in progress has_issue labels Oct 2, 2023
@russoz russoz changed the title [WIP] snap: detect change by checking final state snap: detect change by checking final state Oct 6, 2023
@ansibullbot ansibullbot removed the WIP Work in progress label Oct 6, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 labels Oct 6, 2023
@felixfontein
Copy link
Collaborator

Looks good to me (when glancing over it). Will merge this weekend if nobody objects.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Oct 8, 2023
@felixfontein felixfontein merged commit 323a1dc into ansible-collections:main Oct 8, 2023
@patchback
Copy link

patchback bot commented Oct 8, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/323a1dcff837c4e40491fcb70050b82817764d94/pr-7340

Backported as #7366

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 8, 2023
@russoz @patchback
snap: detect change by checking final state (#7340)
b3abe61 
* snap: detect change by checking final state

* detect change in snap_status variable

* add changelog frag

(cherry picked from commit 323a1dc)
@patchback patchback bot mentioned this pull request Oct 8, 2023
Merged
@felixfontein
Copy link
Collaborator

@russoz thanks for your contribution!
And thanks for everyone who tried this out :)

felixfontein pushed a commit that referenced this pull request Oct 8, 2023
@patchback @russoz
[PR #7340/323a1dcf backport][stable-7] snap: detect change by checkin…
1137642 
…g final state (#7366)

snap: detect change by checking final state (#7340)

* snap: detect change by checking final state

* detect change in snap_status variable

* add changelog frag

(cherry picked from commit 323a1dc)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@russoz russoz deleted the snap-fix branch October 8, 2023 18:29
etrombly pushed a commit to etrombly/community.general that referenced this pull request Oct 25, 2023
@russoz
snap: detect change by checking final state (ansible-collections#7340)
26840bd 
* snap: detect change by checking final state

* detect change in snap_status variable

* add changelog frag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has_issue module module plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ooops! Snap installation failed while executing
3 participants
@russoz @ansibullbot @felixfontein