Ooops! Snap installation failed while executing #7265

onknows · 2023-09-15T05:52:49Z

Summary

This is related to #7130 . This issue #7130 is still not completely fixed. The following code fails on Ubuntu 22.04. I tested this with 7.3.0, 7.4.0. It fails with those versions. The code below does however work when using 6.6.0.

    - name: Install packages
      ansible.builtin.apt:
        name:
          - snapd
          - fuse
          - udev
        state: present
        update_cache: true

    - name: Install Microk8s
      community.general.snap:
        name: microk8s
        classic: true
        channel: 1.26/stable

TASK [Install Microk8s] ********************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible_collections.community.general.plugins.module_utils.mh.exceptions.ModuleHelperException
fatal: [c2d-galaxy1]: FAILED! => changed=false 
  channel: 1.26/stable
  classic: true
  cmd: '[''state'', ''classic'', ''channel'', ''dangerous'', ''microk8s'']'
  msg: Ooops! Snap installation failed while executing '['state', 'classic', 'channel', 'dangerous', 'microk8s']', please examine logs and error output for more details.
  output:
    channel: 1.26/stable
    classic: true
    cmd: '[''state'', ''classic'', ''channel'', ''dangerous'', ''microk8s'']'
    snap_names:
    - microk8s
    snaps_installed:
    - microk8s
  snap_names:
  - microk8s
  snaps_installed:
  - microk8s
  vars:
    channel: 1.26/stable
    classic: true
    cmd: '[''state'', ''classic'', ''channel'', ''dangerous'', ''microk8s'']'
    snap_names:
    - microk8s
    snaps_installed:
    - microk8s

Issue Type

Bug Report

Component Name

snap

Ansible Version

θ97° [:ansible-dev]└2 master(+104/-29,-1)* 130 ± ansible --version
ansible [core 2.15.0]
  config file = /home/onknows/git/gitlab/c2/ansible-dev/ansible-dev.cfg
  configured module search path = ['/home/onknows/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /home/onknows/.virtualenv/c2d/lib/python3.10/site-packages/ansible
  ansible collection location = /home/onknows/git/gitlab/c2/ansible-dev-collections:/home/onknows/git/gitlab/c2/ansible-dev
  executable location = /home/onknows/.virtualenv/c2d/bin/ansible
  python version = 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] (/home/onknows/.virtualenv/c2d/bin/python)
  jinja version = 3.1.2
  libyaml = True

Community.general Version

# /home/onknows/git/gitlab/c2/ansible-dev/ansible_collections
Collection        Version
----------------- -------
community.general 7.4.0

Configuration

    - name: Install packages
      ansible.builtin.apt:
        name:
          - snapd
          - fuse
          - udev
        state: present
        update_cache: true

    - name: Install Microk8s
      community.general.snap:
        name: microk8s
        classic: true
        channel: 1.26/stable

OS / Environment

Ubuntu 22.04

Steps to Reproduce

---
- name: galaxy.yml
  hosts: galaxy
  become: yes

  tasks:

    - name: Install packages
      ansible.builtin.apt:
        name:
          - snapd
          - fuse
          - udev
        state: present
        update_cache: true

    - name: Install Microk8s
      community.general.snap:
        name: microk8s
        classic: true
        channel: 1.26/stable

Expected Results

Snap install like on community.general 6.6.0

Actual Results

TASK [Install Microk8s] ********************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible_collections.community.general.plugins.module_utils.mh.exceptions.ModuleHelperException
fatal: [c2d-galaxy1]: FAILED! => changed=false 
  channel: 1.26/stable
  classic: true
  cmd: '[''state'', ''classic'', ''channel'', ''dangerous'', ''microk8s'']'
  msg: Ooops! Snap installation failed while executing '['state', 'classic', 'channel', 'dangerous', 'microk8s']', please examine logs and error output for more details.
  output:
    channel: 1.26/stable
    classic: true
    cmd: '[''state'', ''classic'', ''channel'', ''dangerous'', ''microk8s'']'
    snap_names:
    - microk8s
    snaps_installed:
    - microk8s
  snap_names:
  - microk8s
  snaps_installed:
  - microk8s
  vars:
    channel: 1.26/stable
    classic: true
    cmd: '[''state'', ''classic'', ''channel'', ''dangerous'', ''microk8s'']'
    snap_names:
    - microk8s
    snaps_installed:
    - microk8s

Code of Conduct

I agree to follow the Ansible Code of Conduct

ansibullbot · 2023-09-15T05:55:49Z

Files identified in the description:

plugins/modules/snap.py

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

ansibullbot · 2023-09-15T05:55:49Z

cc @angristan @vcarceler
click here for bot help

felixfontein · 2023-09-15T21:11:05Z

CC @russoz

russoz · 2023-09-16T03:12:36Z

hi @onknows, thanks for reporting the issue.

Could you please paste the output of the playbook when running with -vvvv? TIA

russoz · 2023-09-17T09:50:39Z

Also, could you please inform:

the version of snap you are using?
the OS distro and version in both the target node and the controller?
the full output of ansible-galaxy collection list community.general?

russoz · 2023-09-17T09:53:10Z

For the record, the problem in #7130 was that the wrong version of the collection was being used. As soon as the user made sure the correct version (7.3.0 at the time), the problem was gone.

onknows · 2023-09-18T06:51:46Z

hi @onknows, thanks for reporting the issue.

Could you please paste the output of the playbook when running with -vvvv? TIA

See provision.log

vagrant@c2d-galaxy1:~$ snap --version
snap    2.60.3
snapd   2.60.3
series  16
ubuntu  22.04
kernel  6.2.0-32-generic

Controller node

onknows@io3:~$ cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=22.04
DISTRIB_CODENAME=jammy
DISTRIB_DESCRIPTION="Ubuntu 22.04.3 LTS"
onknows@io3:~$

Target node:

vagrant@c2d-galaxy1:~$ cat /etc/lsb-release 
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=22.04
DISTRIB_CODENAME=jammy
DISTRIB_DESCRIPTION="Ubuntu 22.04.1 LTS"
vagrant@c2d-galaxy1:~$

Full list:

le-dev]└2 master(+13/-11)* ± ansible-galaxy collection list community.general

# /home/onknows/git/gitlab/c2/ansible-dev/ansible_collections
Collection        Version
----------------- -------
community.general 7.3.0  
θ100° [:ansible-dev]└2 master(+29/-8)* ±

russoz · 2023-09-18T11:56:46Z

Hi @onknows , thanks for the extra info. However, in the output file you attached, I do not see in the output of the module a variable run_info that is only set when using -vvvv (4 times). If you indeed used -vvvv, that would be an indication that maybe we have a different version of the module being used somehow.

Could you please double check and ensure that we have run_info in the output? As an example you can see in #7130 (comment) how the output should look like.

onknows · 2023-09-19T03:35:06Z

Hi @russoz, my bad, I did not see four v, below is the log with -vvvv
provision.log

Voldemat · 2023-09-23T02:58:06Z

Encountered the same problem

Voldemat · 2023-09-27T06:34:50Z

@russoz Hi, is there any news on that?

russoz · 2023-09-27T06:42:28Z

Hi @Voldemat , sorry, haven't had time to work on it these last days. Hopefully on the weekend.

utamas · 2023-09-30T06:26:21Z

@russoz is there any awy I can help? I'm also hitting this issue

sineverba · 2023-09-30T06:52:21Z

Got same issue @russoz

utamas · 2023-09-30T06:57:28Z

provision.log

…y.general/issues/7265](https://github.com/ansible-collections/community.general/issues/7265)

russoz · 2023-10-02T01:20:26Z

Ok, the errors that we have been seeing are coming up during the installation of the snaps. The way the module works today is:

Detect the installed snaps
Install (if needed)

Parsing the installation output to detect whether it was successful or not. However, that seems to be proving less straightforward than expected, so I am changing the logic to:

Detect the installed snaps
Install (if needed)
Detect the final state (and compare with the initial one)

The snap command is not fast (it takes a couple of seconds just to start) and that extra call will be noticed, but it is more reliable that way.

russoz · 2023-10-02T12:00:02Z

hi all,

Please check whether the code in the PR #7340 solves your problem.

As I never got to replicate the problem, I am not confident it does.

Cheers,
AZ

russoz · 2023-10-02T12:01:10Z

^ @utamas @sineverba @Voldemat @onknows

sineverba · 2023-10-02T12:07:12Z

@russoz I can test it in some day, but... how can I test it?

russoz · 2023-10-02T12:48:00Z

In an isolated environment, install it with:

ansible-galaxy collection install git+https://github.com/russoz-ansible/community.general.git,snap-fix

Alternatively, if you don't mind getting your hands dirty, you could clone my fork and manually copy the snap.py file into your current installation, provided you remember to revert that later ;-)

sineverba · 2023-10-02T13:00:49Z

No problem for hands dirty. I use Ansible in Docker ;)

russoz · 2023-10-03T08:48:40Z

Please let us know if/when you manage to replicate the situation using the updated module.

sineverba · 2023-10-03T11:34:35Z

Probably I can test not before the weekend.

utamas · 2023-10-04T09:47:52Z

I'll try shortly.

sineverba · 2023-10-04T10:15:52Z

ERROR! Could not find git executable to extract the collection from the Git repository https://github.com/russoz-ansible/community.general.git.

utamas · 2023-10-04T18:57:12Z

So I copied snap.py and I can confirm that it works like a charm. Thank you @russoz

russoz · 2023-10-04T19:01:32Z

ERROR! Could not find git executable to extract the collection from the Git repository https://github.com/russoz-ansible/community.general.git

Yup, ansible-galaxy will require git to be installed when installing directly from the repository.

sineverba · 2023-10-05T06:00:36Z

Finally I setup via ansible-galaxy and it works ;)

Thank you @russoz

ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) traceback labels Sep 15, 2023

russoz mentioned this issue Sep 17, 2023

DO NOT MERGE: snap test for issue 7265 #7278

Closed

ansibullbot added the has_pr label Sep 18, 2023

sineverba referenced this issue in sineverba/docker-ansible Sep 30, 2023

Fix snap errors. See [https://github.com/ansible-collections/communit…

7575a08

…y.general/issues/7265](https://github.com/ansible-collections/community.general/issues/7265)

sineverba mentioned this issue Sep 30, 2023

Fix snap errors. See [https://github.com/ansible-collections/communit… sineverba/docker-ansible#42

Merged

russoz mentioned this issue Oct 6, 2023

snap: detect change by checking final state #7340

Merged

felixfontein closed this as completed in #7340 Oct 8, 2023

patchback bot mentioned this issue Oct 8, 2023

[PR #7340/323a1dcf backport][stable-7] snap: detect change by checking final state #7366

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ooops! Snap installation failed while executing #7265

Ooops! Snap installation failed while executing #7265

onknows commented Sep 15, 2023 •

edited

Loading

ansibullbot commented Sep 15, 2023

ansibullbot commented Sep 15, 2023

felixfontein commented Sep 15, 2023

russoz commented Sep 16, 2023

russoz commented Sep 17, 2023

russoz commented Sep 17, 2023

onknows commented Sep 18, 2023

russoz commented Sep 18, 2023 •

edited

Loading

onknows commented Sep 19, 2023 •

edited

Loading

Voldemat commented Sep 23, 2023

Voldemat commented Sep 27, 2023

russoz commented Sep 27, 2023

utamas commented Sep 30, 2023

sineverba commented Sep 30, 2023

utamas commented Sep 30, 2023

russoz commented Oct 2, 2023

russoz commented Oct 2, 2023

russoz commented Oct 2, 2023

sineverba commented Oct 2, 2023

russoz commented Oct 2, 2023

sineverba commented Oct 2, 2023

russoz commented Oct 3, 2023 •

edited

Loading

sineverba commented Oct 3, 2023

utamas commented Oct 4, 2023

sineverba commented Oct 4, 2023

utamas commented Oct 4, 2023

russoz commented Oct 4, 2023 •

edited

Loading

sineverba commented Oct 5, 2023 •

edited

Loading

Ooops! Snap installation failed while executing #7265

Ooops! Snap installation failed while executing #7265

Comments

onknows commented Sep 15, 2023 • edited Loading

Summary

Issue Type

Component Name

Ansible Version

Community.general Version

Configuration

OS / Environment

Steps to Reproduce

Expected Results

Actual Results

Code of Conduct

ansibullbot commented Sep 15, 2023

ansibullbot commented Sep 15, 2023

felixfontein commented Sep 15, 2023

russoz commented Sep 16, 2023

russoz commented Sep 17, 2023

russoz commented Sep 17, 2023

onknows commented Sep 18, 2023

russoz commented Sep 18, 2023 • edited Loading

onknows commented Sep 19, 2023 • edited Loading

Voldemat commented Sep 23, 2023

Voldemat commented Sep 27, 2023

russoz commented Sep 27, 2023

utamas commented Sep 30, 2023

sineverba commented Sep 30, 2023

utamas commented Sep 30, 2023

russoz commented Oct 2, 2023

russoz commented Oct 2, 2023

russoz commented Oct 2, 2023

sineverba commented Oct 2, 2023

russoz commented Oct 2, 2023

sineverba commented Oct 2, 2023

russoz commented Oct 3, 2023 • edited Loading

sineverba commented Oct 3, 2023

utamas commented Oct 4, 2023

sineverba commented Oct 4, 2023

utamas commented Oct 4, 2023

russoz commented Oct 4, 2023 • edited Loading

sineverba commented Oct 5, 2023 • edited Loading

onknows commented Sep 15, 2023 •

edited

Loading

russoz commented Sep 18, 2023 •

edited

Loading

onknows commented Sep 19, 2023 •

edited

Loading

russoz commented Oct 3, 2023 •

edited

Loading

russoz commented Oct 4, 2023 •

edited

Loading

sineverba commented Oct 5, 2023 •

edited

Loading