Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #5672/fab73a1d backport][stable-5] Bugfix: Remove redundant VMID parameters #5708

Merged
merged 1 commit into from
Dec 19, 2022
Merged

[PR #5672/fab73a1d backport][stable-5] Bugfix: Remove redundant VMID parameters #5708

merged 1 commit into from
Dec 19, 2022

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Dec 19, 2022

This is a backport of PR #5672 as merged into main (fab73a1).

SUMMARY

Removed redundant VMID parameter from URI builder from all functions in proxmox_disk and proxmox_nic modules.

It fixes possible issues similar to #5492.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxmox_disk
proxmox_nic

ADDITIONAL INFORMATION

Conversation about this fix was here.

Modified functions have been tested with:

  • Controller: openSUSE Tumbleweed (python 3.10)
  • Target: Proxmox 7.3-3
  • Ansible:
    • core 2.14.1
    • community-general 6.1.0
  • Proxmoxer: 2.0.0
  • Requests: 2.28.1

@castorsky @patchback
Bugfix: Remove redundant VMID parameters (#5672)
8699218 
* Remove redundant parameters VMID

* Add changelog fragment

(cherry picked from commit fab73a1)
@patchback patchback bot mentioned this pull request Dec 19, 2022
Merged
@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Dec 19, 2022
@felixfontein felixfontein merged commit 40d094e into stable-5 Dec 19, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-5/fab73a1d1e168fc04a5723d45bb3251149d9d856/pr-5672 branch December 19, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixfontein @ansibullbot @castorsky